Converted Type Annotations to Py3 syntax

aio-libs / aiodns

Simple DNS resolver for asyncio

https://pypi.python.org/pypi/aiodns

MIT License

532 stars 69 forks source link

Converted Type Annotations to Py3 syntax #77

Closed mimi89999 closed 4 years ago

mimi89999 commented 4 years ago

Type annotations are very long for this project. Not sure what to do about that. Maybe they should be defined somewhere else?

saghul commented 4 years ago

Thank you!

However this seems to break in Python 3.5: https://travis-ci.org/saghul/aiodns/jobs/624322207?utm_medium=notification&utm_source=github_status

mimi89999 commented 4 years ago

I think that it would be very inconsistent to keep variable annotations as comments and use Python3.6 syntax for function annotations. How long will Python3.5 be supported by aiodns?

mimi89999 commented 4 years ago

I reverted variable annotations.

saghul commented 4 years ago

How long will Python3.5 be supported by aiodns?

For the foreseable future. Ubuntu 16.04, which is LTS has 3.5, for example.

saghul commented 4 years ago

Merged, thank you!