Remove loop= param from asyncio.sleep() to fix tests on Python 3.10

aio-libs / aiodns

Simple DNS resolver for asyncio

https://pypi.python.org/pypi/aiodns

MIT License

538 stars 69 forks source link

Closed mgorny closed 3 years ago

mgorny commented 3 years ago

Fixes #95

mgorny commented 3 years ago

I've also attempted enabling GHA testing on 3.10.

saghul commented 3 years ago

Looks like we need to install the wheel package to make sure building works.

mgorny commented 3 years ago

Yeah, I'm guessing this is because either some of the low-level stuff (pip?) or GHA hasn't been yet all synced for 3.10 deprecations.

mgorny commented 3 years ago

Windows seems to be unhappy but I don't really know how to fix it.

saghul commented 3 years ago

Let's exclude it for now. Linux and macOS pass, which is a good indication :-)

I think you can add a "excludes" section to the build matrix to skip 3.10 on Windows.

mgorny commented 3 years ago

Let's try that but I think the wheel install stage could be causing the hangs on 3.8/3.9 jobs too.

saghul commented 3 years ago

Not sure why Windows is getting stuck on Python 3.8/3.9 but that's not related to your PR. Merged!