Closed achimnol closed 2 months ago
Attention: Patch coverage is 84.89209%
with 21 lines
in your changes missing coverage. Please review.
Project coverage is 81.14%. Comparing base (
7b3d86f
) to head (d6ccbe0
).
Files | Patch % | Lines |
---|---|---|
aiodocker/logs.py | 11.11% | 8 Missing :warning: |
aiodocker/docker.py | 69.56% | 4 Missing and 3 partials :warning: |
aiodocker/containers.py | 85.00% | 1 Missing and 5 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Currently the Windows test in CI seems to be broken in an unexpected way. In my local Windows box (standard Docker Desktop + Python 3.12.4 from chocolatey), it works well with a minor glitch:
refs #847
from __future__ import annotations
.DockerContainer.log()
,DockerContainer.stats()
likeDockerImage.pull()
.JSONObject
,JSONList
,JSONValue
for API arguments, but not in the return values due to the type variance issue. In the future, it would be better to adopt explicitly typed DTOs.filters
arg used in many places.windows/amd64
platform weighs more than 2 GiB, while the alpine version is less than 20 MiB. This makes it to time out in high probability if pulled in pytest, as the pull takes more than 10 minutes. Unfortunately, there is no slim variants for thewindows/amd64
platform.docker pull
step explicitly before running pytest in CI, so that we can observe the pulling progress and decouple the timeout from pytest.docker load
anddocker save
simply takes a tooooo long time, so it's meaningless to improve the download speed by caching.Checklist
CONTRIBUTORS.txt
changes
folder<issue_id>.<type>
for example (588.bug)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.