Closed eevelweezel closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 81.34%. Comparing base (
167301f
) to head (16c4ff1
).:exclamation: Current head 16c4ff1 differs from pull request most recent head f5763c0
Please upload reports for the commit f5763c0 to get more accurate results.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Pre-commit only supports Python 3.9+ as of v3.6.0, so I changed the requirement to pre-commit>=3.5.0 in order to support Python 3.8.
Could we also adopt
setuptools_scm
to automate the version mangling based on the latest git tags?
Since we're using hatchling, I used hatch-vcs, which delivers the same functionality. I've also rebased against master.
What do these changes do?
This updates pyproject.toml to support new-style packaging with hatch, instead of setuptools / setup.py.
The existing requirements files have been combined into "dependencies" (always installed), "dev" (anything dev, lint, or testing), and "doc" (needed to build the docs). With the optional dependencies, I was trying to follow convention I've seen elsewhere. Feedback would be welcome.
Are there changes in behavior for the user?
Instead of using
pip install -r requirements/...
, the package can now be installed withpip install -e .[dev,doc]
(where "dev" and "doc" are optional dependency groups).Related issue number
848
Checklist
CONTRIBUTORS.txt
changes
folder<issue_id>.<type>
for example (588.bug)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.