Closed fregataa closed 2 months ago
Attention: Patch coverage is 75.00000%
with 3 lines
in your changes missing coverage. Please review.
Project coverage is 81.25%. Comparing base (
906d8c5
) to head (f7a9476
).:exclamation: Current head f7a9476 differs from pull request most recent head 4e85c33
Please upload reports for the commit 4e85c33 to get more accurate results.
Files | Patch % | Lines |
---|---|---|
aiodocker/containers.py | 70.00% | 3 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
What do these changes do?
utils._AsyncCM
objects have a_coro
coroutine type field. In some cases, it is not awaited and it raises RuntimeWarning like belowOne of the suspicious parts is from
Container.log()
. Let's close the coroutine if any error occurs.Are there changes in behavior for the user?
They will not see
RuntimeWarning
anymore!Related issue number
Checklist
CONTRIBUTORS.txt
changes
folder<issue_id>.<type>
for example (588.bug)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.