Closed fregataa closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 81.10%. Comparing base (
5148c63
) to head (49b51e4
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
What do these changes do?
Sentinel
singleton value to allowNone
(infinite timeout) arguments in theDocker._query()
andDocker._do_query()
based APIs.timeout
parameter toDockerImages.pull()
method.Are there changes in behavior for the user?
Users can now pass a float or
None
to thetimeout
parameter in the pull() API. Previously,None
meant the fallback to the session-configured default timeout, and thus users could not set the infinite timeout for specific API queries like pulling.If the user code has not set any timeout argument, they will work as the same: falling back to the session-level timeout. If the user code has deliberately set the timeout to
None
, their semantics are changed from the fallback session-level timeouts to individually set infinite timeouts ignoring the session-level timeout.Checklist
changes
folder<issue_id>.<type>
for example (588.bug)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.