Closed ch3pjw closed 4 years ago
Merging #130 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #130 +/- ##
=======================================
Coverage 99.04% 99.04%
=======================================
Files 6 6
Lines 1878 1878
=======================================
Hits 1860 1860
Misses 18 18
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 94e272d...6c102dc. Read the comment docs.
The tutorial didn't work for me because
Client.context()
assumed the second argument was the port, not the username. Using keyword arguments solves the problem.What do these changes do?
Make the tutorial work with
aioftp == 0.18.0
Are there changes in behavior for the user?
Only that the tutorial should work out the box!
Related issue number
Checklist
Unit tests for the changes existAdd a new news fragment into theCHANGES
folder<issue_id>.<type>
(e.g.588.bugfix
)issue_id
change it to the pr id after creating the PR.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.