Closed janneronkko closed 2 years ago
I faced this issue with a service I've implemented; all the clients connecting to our service do not use EPSV command (using EPSV would have worked)
Merging #150 (0a92e16) into master (ad28ae9) will increase coverage by
0.00%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #150 +/- ##
=======================================
Coverage 99.15% 99.15%
=======================================
Files 6 6
Lines 1888 1891 +3
=======================================
+ Hits 1872 1875 +3
Misses 16 16
Impacted Files | Coverage Δ | |
---|---|---|
aioftp/server.py | 98.38% <100.00%> (+<0.01%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update ad28ae9...0a92e16. Read the comment docs.
Thank you for the PR, released as 0.21.0.
This allows old FTP client to connect to AIOFtp server located behind NAT.
What do these changes do?
The change adds support for clients using passive connections (PASV command) to a server located behind NAT
Are there changes in behavior for the user?
Passive connections can be opened with PASV command to server behind (IPv4) NAT
Related issue number
N/A
Checklist
CHANGES
folder -- there is no CHANGES folder<issue_id>.<type>
(e.g.588.bugfix
)issue_id
change it to the pr id after creating the PR.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.