search

aio-libs / aioftp

ftp client/server for asyncio (http://aioftp.readthedocs.org)
Apache License 2.0
185 stars 54 forks source link

Please tag release revisions in git #153

Open risicle opened 2 years ago

risicle commented 2 years ago

It doesn't look like there has been a tag for a release revision since 2019. Without these, figuring out the exact source corresponding the the version you're running is painful.

pohmelie commented 2 years ago

I don't get the problem, you can recognize version via python -m pip list | grep aioftp.

risicle commented 2 years ago

That doesn't give you the source. It tells you a version number (if you're using pip, and not everyone is). If you then need to see the exact source corresponding to that particular version and the git details of what patches have or have not been merged into your version, you have to browse github until you figure it out. It's one of those small things that makes it much easier for a user to productively interact with the project, track down problematic PR merges, etc..

pohmelie commented 2 years ago

I don't know how you can use lib without pip... actually I can imagine this, but see no reasons for this. Anyway you install package from pypi or your distro repo. They both have version information. Every release have release commit like this https://github.com/aio-libs/aioftp/commit/f705cdfadc3e47266798955fbeb747d0950a9ad6. It is more than enough to recognize exact source point of repository. Tag adds nothing here and useless.

risicle commented 2 years ago

The most useful thing having tags-for-versions does is make github show at a glance, for any commit, which versions that commit made it into - or if it's only in master and hasn't made it in to a release yet.

Screenshot_20220528_111029

It also allows someone to do e.g. https://github.com/python-ldap/python-ldap/compare/python-ldap-3.1.0...python-ldap-3.3.1

pohmelie commented 2 years ago

This feature (if someone needs it) works fine for commits: https://github.com/aio-libs/aioftp/compare/9118e912...f705cdfa. Of course this is less readable, but I've never used such comparsions directly in github. Probably, because gitlab is popular for local usage in big companies.

pohmelie commented 2 years ago

I see likes on your comment, so I add tags.