search

aio-libs / aiohappyeyeballs

Happy Eyeballs for pre-resolved hosts
Other
11 stars 9 forks source link

fix: correct classifier for license Python-2.0.1 #83

Closed tungh2 closed 3 months ago

tungh2 commented 3 months ago

What do these changes do?

Correct classifier for license Python-2.0.1 according to available classifiers listed at https://pypi.org/classifiers/

Without this patch, pip-licenses disrupted CI license check with below error which was not raised at version prior 2.3.5.

license Other/Proprietary License not in allow-only licenses was found for package aiohappyeyeballs:2.3.6

It seems that the change was made by this commit, which correctly removed CNRI Python License part but unfortunately didn't update properly which is this PR for.

Are there changes in behavior for the user?

There is no change in functionalities except license checking above.

Related issue number

Checklist

tungh2 commented 3 months ago

@bdraco Hi there, appreciate if you could take a look. The issue is currently blocking our internal CI license checking.

From what I investigated, the fix is sensible in that it made perfect the previous commit as mentioned in the PR description.

bdraco commented 3 months ago

I’m not sure the classifier is the same but it’s the nearest match so let’s do it

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (30a2dc5) to head (ac46586). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #83 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 4 4 Lines 160 160 Branches 43 43 ========================================= Hits 160 160 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tungh2 commented 3 months ago

Thank you, really appreciate your fast approval!

tungh2 commented 3 months ago

Just want to share, the new 2.3.7 release did fix our license check CI 🎉 

 aiohappyeyeballs                2.3.7             Other/Proprietary License; Python Software Foundation License
apbeers commented 2 months ago

This fixed my issue too! Thanks so much!