Refactor aiohttp-debugtoolbar to use new aiohttp sub application

aio-libs / aiohttp-debugtoolbar

aiohttp_debugtoolbar is library for debugtoolbar support for aiohttp

Apache License 2.0

195 stars 31 forks source link

Refactor aiohttp-debugtoolbar to use new aiohttp sub application #71

Open jettify opened 7 years ago

jettify commented 7 years ago

Create separate app for aiohttp-debugtoolbar
Hide all toolbar related URL behind this sub app

samuelcolvin commented 7 years ago

Any progress on this?

Currently aiohttp-debugtoolbar is more or less unusable with sub apps AFAIK. Or is there a workaround I'm missing?

Even if DBTB doesn't support sub-apps completely it shouldn't completely break when they are used, see https://github.com/samuelcolvin/aiohttp-devtools/issues/39.

jettify commented 7 years ago

Toolbar had been crated long before aiohttp introduced subapp feature, this improvement is more about proper code plug in, then functionality. I don not have any ETA for this, but PR is welcome

Dreamsorcerer commented 10 months ago

Once this is done, we can also switch jinja templates to use static() for URLs (see #478).