Closed Olegt0rr closed 6 months ago
Hi possible to merge this ?
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
21cb76e
) 99.47% compared to head (b97c9ce
) 99.49%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
What do these changes do?
Since https://github.com/aio-libs/aiohttp/issues/3105 is abandoned for many years, I think we can make simple way to check SSE state (based on ping). After 3105 problem become closed, it will be possible to rely on the new logic in this method, saving the contract.
Are there changes in behaviour for the user?
Added the ability to publicly access the connection status via
.is_connected()
method.Related issue number
Closes #391
Checklist
CHANGES
folder<issue_id>.<type>
(e.g.588.bugfix
)issue_id
change it to the pr id after creating the PR.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.