aio-libs / aiohttp-sse

Server-sent events support for aiohttp
Other
197 stars 36 forks source link

Don't cancel self (v2) #457

Closed Olegt0rr closed 8 months ago

Olegt0rr commented 8 months ago

What do these changes do?

https://github.com/aio-libs/aiohttp-sse/pull/456#pullrequestreview-1860917238

Are there changes in behavior for the user?

Adds some warnings if EventSource was used wrong way

Related issue number

no issue

Checklist

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7fdb432) 100.00% compared to head (26fa6a0) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #457 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 4 4 Lines 452 458 +6 Branches 52 53 +1 ========================================= + Hits 452 458 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Olegt0rr commented 8 months ago

I'll make another PR with cancel swallowing