aio-libs / aiohttp

Asynchronous HTTP client/server framework for asyncio and Python
https://docs.aiohttp.org
Other
15.13k stars 2.02k forks source link

Introduce `session.make_request()` API #2019

Open asvetlov opened 7 years ago

asvetlov commented 7 years ago

Now we support request payload streaming in a bit reverse way: we could pass a generator as data parameter to client.request() but it makes things harder because of Reverse of Control. Handling back pressure and errors in generator are complicated. Also sometimes people should pass semi-supported custom request_class for calculating custom headers etc. Last Trailer headers support #1652 also requires some kind of callback -- which is not elegant at least.

I suggest adding new client.make_request(url, params, headers, ...) method. The method returns ClientStreamRequest object.

The request is not started at moment of creation but has headers prepared. User could modify them without subclassing.

The request has .connect() coroutine for connection negotiation (it works with proxies implicitly). After connection established user calls .send_headers() coro, later .write() coro several times maybe, .send_trailers() if needed and .write_eof(). ClientStreamRequest API should be pretty much close to web.StreamResponse.

All existing client API should be built around ClientStreamRequest calls.

I pretty sure this is viable approach that might make non-trivial usages much simpler than now.

fafhrd91 commented 7 years ago

I like it

kxepal commented 7 years ago

+1

alexmnazarenko commented 7 years ago

+1, it would be nice for my use-case (essentially, app sometimes behaves like a proxy server, so it is forced to use streaming APIs)