Closed kloczek closed 1 year ago
kloczek
commented
2 years ago Looks like provided Makefile has hardcoded pyton executable name 🤔
[tkloczko@devel-g2v aiohttp-3.8.1]$ make cythonize
make: python: No such file or directory
make: *** [Makefile:50: .update-pip] Error 127
Dreamsorcerer
commented
2 years ago Looks like provided Makefile has hardcoded pyton executable name
As opposed to? @greshilov just changed it from pip -> python, but I'm not sure how much difference that makes to you (#6756).
kloczek
commented
2 years ago Nevertheless cythonize should be integrated into setup.py 😋
Dreamsorcerer
commented
2 years ago Feel free to make a PR, I'm not familiar with cythonize myself.
kloczek
commented
2 years ago Still pep517 build soes not work (master + that PR)
kloczek
commented
2 years ago Feel free to make a PR, I'm not familiar with cythonize myself.
You can peak on https://github.com/fastavro/fastavro/pull/602
webknjaz
commented
2 years ago Cythonize used to be a part of setup.py but now it is opt-in.
kloczek
commented
2 years ago FYI in that comment https://github.com/fastavro/fastavro/issues/600#issuecomment-1133071463 I've dropped details about other projests in which is cython is used and pep517 Works ™️
kloczek
commented
2 years ago BTW just found that tjis issue is only when git source tree is used. When pypi sdist is used pep517 is OK.
However that is obviouse because sdist includes missing files which are generated on forming sdist archive,
layday
commented
2 years ago Is there a reason that cython isn't specified as a build dependency? That's all that's needed to make sdist installs work with pip - the files generated by cythonize are bundled in the sdist.
kloczek
commented
2 years ago Just FTR. There are plenty of exampes of how to hadle cythonize in pyproject.toml setup.cfg
[tkloczko@devel-g2v SPECS]$ grep 'BuildRequires:.*python3dist(cython)' * -l | xargs grep -h ^VCS
VCS: https://github.com/blueman-project/blueman/
VCS: https://github.com/brltty/brltty/
VCS: https://github.com/google/brotli/
VCS: https://github.com/fonttools/fonttools/
VCS: https://github.com/ofalk/libdnet/
VCS: https://github.com/libimobiledevice/libplist/
VCS: https://salsa.debian.org/samba-team/talloc/
VCS: https://github.com/mesonbuild/meson/
VCS: https://github.com/aio-libs/aiohttp/
VCS: https://github.com/MagicStack/asyncpg/
VCS: https://github.com/Unidata/cftime/
VCS: https://github.com/evhub/cpyparsing/
VCS: https://github.com/microsoft/debugpy/
VCS: https://github.com/roy-ht/editdistance/
VCS: https://github.com/asottile/editdistance-s/
VCS: https://github.com/astropy/extension-helpers/
VCS: https://github.com/falconry/falcon/
VCS: https://github.com/fastavro/fastavro/
VCS: https://github.com/aio-libs/frozenlist/
VCS: https://github.com/gevent/gevent/
VCS: https://github.com/pythongssapi/python-gssapi/
VCS: https://github.com/trezor/cython-hidapi/
VCS: https://github.com/tbodt/htmlpyever/
VCS: https://github.com/ionelmc/python-hunter/
VCS: https://github.com/ipython/ipython/
VCS: https://github.com/getlogbook/logbook/
VCS: https://github.com/scoder/lupa/
VCS: https://github.com/lxml/lxml/
VCS: https://github.com/mpi4py/mpi4py/
VCS: https://github.com/msgpack/msgpack-python/
VCS: https://github.com/aio-libs/multidict/
VCS: https://github.com/numpy/numpy/
VCS: https://github.com/simonpercivall/orderedset/
VCS: https://github.com/pandas-dev/pandas/
VCS: https://github.com/CoreSecurity/pcapy/
VCS: https://github.com/samuelcolvin/pydantic/
VCS: https://github.com/Kijewski/pyjson5/
VCS: https://github.com/yaml/pyyaml/
VCS: https://github.com/tomerfiliba/reedsolomon/
VCS: https://sf.net/p/ruamel-yaml-clib/code/
VCS: https://github.com/scipy/scipy/
VCS: https://github.com/astropy/sphinx-automodapi/
VCS: https://github.com/alexmojaki/stack_data/
VCS: https://github.com/sympy/sympy/
VCS: https://github.com/twisted/twisted/
VCS: https://github.com/MagicStack/uvloop/
VCS: https://github.com/aio-libs/yarl/
VCS: https://github.com/zeromq/pyzmq/
VCS: https://github.com/linux-rdma/rdma-core/
VCS: https://github.com/rrthomas/recode/
VCS: https://github.com/vapoursynth/vapoursynth/I'm closing tg=his ticket as looks like 3.8.4 is OK now
Describe the bug
Looks like cythonize is not integrated in setup.py and by this pep517 based build fails
To Reproduce
Run
/usr/bin/python3 -sBm build -w --no-isolationin project root directoryExpected behavior
Whatever additional steps is necessary to perform all that should be integrated to allow build module DSOs using
buildmodule.Logs/tracebacks