3.8.4: pytest is failing in 9 units

I explained somewhere already that those tests are important and correct.

Really .. the best would be used for that just pylint and only in CI and not in actual test suite.

Updated pytest output of the 3.9.5 with python 3.10.14 and pytest 8.1.1 with excluded units checking circular imports

Here is pytest output:

```console + PYTHONPATH=/home/tkloczko/rpmbuild/BUILDROOT/python-aiohttp-3.9.5-2.fc37.x86_64/usr/lib64/python3.10/site-packages:/home/tkloczko/rpmbuild/BUILDROOT/python-aiohttp-3.9.5-2.fc37.x86_64/usr/lib/python3.10/site-packages + /usr/bin/pytest -ra -m 'not network' -p no:randomly -m 'not dev_mode' --ignore tests/autobahn/test_autobahn.py --deselect 'tests/test_circular_imports.py::test_no_warnings[aiohttp._helpers]' --deselect 'tests/test_circular_imports.py::test_no_warnings[aiohttp._http_parser]' --deselect 'tests/test_circular_imports.py::test_no_warnings[aiohttp._http_writer]' --deselect 'tests/test_circular_imports.py::test_no_warnings[aiohttp._websocket]' ==================================================================================== test session starts ==================================================================================== platform linux -- Python 3.10.14, pytest-8.1.1, pluggy-1.4.0 rootdir: /home/tkloczko/rpmbuild/BUILD/aiohttp-3.9.5 configfile: setup.cfg testpaths: tests/ plugins: mock-3.14.0 collected 3124 items / 10 deselected / 3114 selected tests/test_base_protocol.py .................... [ 0%] tests/test_circular_imports.py ............................................. [ 2%] tests/test_classbasedview.py .... [ 2%] tests/test_client_connection.py ......... [ 2%] tests/test_client_exceptions.py ........................... [ 3%] tests/test_client_fingerprint.py ............ [ 3%] tests/test_client_functional.py .................................................................................................................x................................... [ 8%] ...............................x [ 9%] tests/test_client_proto.py ........... [ 9%] tests/test_client_request.py ......................................................................................................................................... [ 14%] tests/test_client_response.py ........................................................ [ 16%] tests/test_client_session.py ..........................................s..FF........ [ 17%] tests/test_client_ws.py ........................... [ 18%] tests/test_client_ws_functional.py ................................ [ 19%] tests/test_connector.py ....x....................................................................................................sss...........s............. [ 24%] tests/test_cookiejar.py .............................................. [ 25%] tests/test_flowcontrol_streams.py ............. [ 25%] tests/test_formdata.py .......... [ 26%] tests/test_helpers.py ................................................................................................................... [ 29%] tests/test_http_exceptions.py ................... [ 30%] tests/test_http_parser.py ........................................................................xx..............................................................x.................. [ 35%] ...............................................................................x..................................................................................................... [ 41%] ....................................xx.....................................................................................................................................x......... [ 47%] ................... [ 47%] tests/test_http_writer.py ..................... [ 48%] tests/test_imports.py ..F [ 48%] tests/test_locks.py ... [ 48%] tests/test_loop.py ..... [ 48%] tests/test_multipart.py ............................................................................................................. [ 52%] tests/test_multipart_helpers.py ...............s.................................................ss......ss............................ [ 55%] tests/test_payload.py .............. [ 56%] tests/test_proxy.py ................. [ 56%] tests/test_proxy_functional.py ss..........ss........ [ 57%] tests/test_pytest_plugin.py F... [ 57%] tests/test_resolver.py .................... [ 58%] tests/test_route_def.py ...................... [ 58%] tests/test_run_app.py ....................................................... [ 60%] tests/test_streams.py ................................................................................................................ [ 64%] tests/test_tcp_helpers.py ...... [ 64%] tests/test_test_utils.py ................................................ [ 65%] tests/test_tracing.py ................... [ 66%] tests/test_urldispatch.py ............................................................................................................................................. [ 71%] tests/test_web_app.py ............................s........... [ 72%] tests/test_web_cli.py .......... [ 72%] tests/test_web_exceptions.py ...................... [ 73%] tests/test_web_functional.py ...........................x........................................................................................... [ 77%] tests/test_web_log.py ........... [ 77%] tests/test_web_middleware.py ................................................................................................................... [ 81%] tests/test_web_request.py ........................................................................................................ [ 84%] tests/test_web_request_handler.py .... [ 84%] tests/test_web_response.py ............................................................................................................................................... [ 89%] tests/test_web_runner.py ..........ss...... [ 89%] tests/test_web_sendfile.py ..... [ 90%] tests/test_web_sendfile_functional.py .......................................................................................... [ 92%] tests/test_web_server.py .x......... [ 93%] tests/test_web_urldispatcher.py ..................................xxx [ 94%] tests/test_web_websocket.py .................................................... [ 96%] tests/test_web_websocket_functional.py ............................ [ 97%] tests/test_websocket_handshake.py .................... [ 97%] tests/test_websocket_parser.py .......................................... [ 99%] tests/test_websocket_writer.py ........FF.... [ 99%] tests/test_worker.py ................. [100%] ========================================================================================= FAILURES ========================================================================================== _____________________________________________________________________________ test_client_session_timeout_zero ______________________________________________________________________________ self = , req = , traces = [] timeout = ClientTimeout(total=10, connect=0, sock_read=0, sock_connect=0, ceil_threshold=5) async def _create_direct_connection( self, req: ClientRequest, traces: List["Trace"], timeout: "ClientTimeout", *, client_error: Type[Exception] = ClientConnectorError, ) -> Tuple[asyncio.Transport, ResponseHandler]: sslcontext = self._get_ssl_context(req) fingerprint = self._get_fingerprint(req) host = req.url.raw_host assert host is not None # Replace multiple trailing dots with a single one. # A trailing dot is only present for fully-qualified domain names. # See https://github.com/aio-libs/aiohttp/pull/7364. if host.endswith(".."): host = host.rstrip(".") + "." port = req.port assert port is not None try: # Cancelling this lookup should not cancel the underlying lookup # or else the cancel event will get broadcast to all the waiters # across all connections. > hosts = await self._resolve_host(host, port, traces=traces) client_error = fingerprint = None host = 'example.com' port = 80 req = self = sslcontext = None timeout = ClientTimeout(total=10, connect=0, sock_read=0, sock_connect=0, ceil_threshold=5) traces = [] ../../BUILDROOT/python-aiohttp-3.9.5-2.fc37.x86_64/usr/lib64/python3.10/site-packages/aiohttp/connector.py:1203: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ ../../BUILDROOT/python-aiohttp-3.9.5-2.fc37.x86_64/usr/lib64/python3.10/site-packages/aiohttp/connector.py:880: in _resolve_host return await asyncio.shield(resolved_host_task) host = 'example.com' key = ('example.com', 80) port = 80 resolved_host_task = exception=gaierror(-2, 'Name or service not known')> self = traces = [] ../../BUILDROOT/python-aiohttp-3.9.5-2.fc37.x86_64/usr/lib64/python3.10/site-packages/aiohttp/connector.py:917: in _resolve_host_with_throttle addrs = await self._resolver.resolve(host, port, family=self._family) host = 'example.com' key = ('example.com', 80) port = 80 self = traces = [] ../../BUILDROOT/python-aiohttp-3.9.5-2.fc37.x86_64/usr/lib64/python3.10/site-packages/aiohttp/resolver.py:33: in resolve infos = await self._loop.getaddrinfo( family = 0 hostname = 'example.com' port = 80 self = /usr/lib64/python3.10/asyncio/base_events.py:863: in getaddrinfo return await self.run_in_executor( family = 0 flags = getaddr_func = host = 'example.com' port = 80 proto = 0 self = <_UnixSelectorEventLoop running=False closed=False debug=False> type = /usr/lib64/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(*self.args, **self.kwargs) self = None _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ host = 'example.com', port = 80, family = 0, type = , proto = 0, flags = def getaddrinfo(host, port, family=0, type=0, proto=0, flags=0): """Resolve host and port into list of address info entries. Translate the host/port argument into a sequence of 5-tuples that contain all the necessary arguments for creating a socket connected to that service. host is a domain name, a string representation of an IPv4/v6 address or None. port is a string service name such as 'http', a numeric port number or None. By passing None as the value of host and port, you can pass NULL to the underlying C API. The family, type and proto arguments can be optionally specified in order to narrow the list of addresses returned. Passing zero as a value for each of these arguments selects the full range of results. """ # We override this function since we want to translate the numeric family # and socket type values to enum constants. addrlist = [] > for res in _socket.getaddrinfo(host, port, family, type, proto, flags): E socket.gaierror: [Errno -2] Name or service not known addrlist = [] family = 0 flags = host = 'example.com' port = 80 proto = 0 type = /usr/lib64/python3.10/socket.py:955: gaierror The above exception was the direct cause of the following exception: async def test_client_session_timeout_zero() -> None: timeout = client.ClientTimeout(total=10, connect=0, sock_connect=0, sock_read=0) try: async with ClientSession(timeout=timeout) as session: > await session.get("http://example.com") session = timeout = ClientTimeout(total=10, connect=0, sock_read=0, sock_connect=0, ceil_threshold=5) tests/test_client_session.py:821: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ ../../BUILDROOT/python-aiohttp-3.9.5-2.fc37.x86_64/usr/lib64/python3.10/site-packages/aiohttp/client.py:581: in _request conn = await self._connector.connect( all_cookies = allow_redirects = True auth = None auth_from_url = None auto_decompress = True chunked = None compress = None cookies = None data = None expect100 = False fingerprint = None handle = None headers = history = [] json = None max_field_size = 8190 max_line_size = 8190 max_redirects = 10 method = 'GET' params = {} proxy = None proxy_auth = None proxy_headers = raise_for_status = None read_bufsize = 65536 read_until_eof = True real_timeout = ClientTimeout(total=10, connect=0, sock_read=0, sock_connect=0, ceil_threshold=5) redirects = 0 req = self = server_hostname = None skip_auto_headers = None skip_headers = set() ssl = True ssl_context = None str_or_url = 'http://example.com' timeout = <_SENTINEL.sentinel: 1> timer = tm = trace_request_ctx = None traces = [] url = URL('http://example.com') verify_ssl = None version = HttpVersion(major=1, minor=1) ../../BUILDROOT/python-aiohttp-3.9.5-2.fc37.x86_64/usr/lib64/python3.10/site-packages/aiohttp/connector.py:544: in connect proto = await self._create_connection(req, traces, timeout) available = 100 key = ConnectionKey(host='example.com', port=80, is_ssl=False, ssl=True, proxy=None, proxy_auth=None, proxy_headers_hash=None) placeholder = proto = None req = self = timeout = ClientTimeout(total=10, connect=0, sock_read=0, sock_connect=0, ceil_threshold=5) traces = [] ../../BUILDROOT/python-aiohttp-3.9.5-2.fc37.x86_64/usr/lib64/python3.10/site-packages/aiohttp/connector.py:944: in _create_connection _, proto = await self._create_direct_connection(req, traces, timeout) req = self = timeout = ClientTimeout(total=10, connect=0, sock_read=0, sock_connect=0, ceil_threshold=5) traces = [] _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ self = , req = , traces = [] timeout = ClientTimeout(total=10, connect=0, sock_read=0, sock_connect=0, ceil_threshold=5) async def _create_direct_connection( self, req: ClientRequest, traces: List["Trace"], timeout: "ClientTimeout", *, client_error: Type[Exception] = ClientConnectorError, ) -> Tuple[asyncio.Transport, ResponseHandler]: sslcontext = self._get_ssl_context(req) fingerprint = self._get_fingerprint(req) host = req.url.raw_host assert host is not None # Replace multiple trailing dots with a single one. # A trailing dot is only present for fully-qualified domain names. # See https://github.com/aio-libs/aiohttp/pull/7364. if host.endswith(".."): host = host.rstrip(".") + "." port = req.port assert port is not None try: # Cancelling this lookup should not cancel the underlying lookup # or else the cancel event will get broadcast to all the waiters # across all connections. hosts = await self._resolve_host(host, port, traces=traces) except OSError as exc: if exc.errno is None and isinstance(exc, asyncio.TimeoutError): raise # in case of proxy it is not ClientProxyConnectionError # it is problem of resolving proxy ip itself > raise ClientConnectorError(req.connection_key, exc) from exc E aiohttp.client_exceptions.ClientConnectorError: Cannot connect to host example.com:80 ssl:default [Name or service not known] client_error = fingerprint = None host = 'example.com' port = 80 req = self = sslcontext = None timeout = ClientTimeout(total=10, connect=0, sock_read=0, sock_connect=0, ceil_threshold=5) traces = [] ../../BUILDROOT/python-aiohttp-3.9.5-2.fc37.x86_64/usr/lib64/python3.10/site-packages/aiohttp/connector.py:1209: ClientConnectorError _________________________________________________________________________ test_client_session_timeout_bad_argument __________________________________________________________________________ cls = , func = . at 0x7ff60b4b3d90>, when = 'call' reraise = (, ) @classmethod def from_call( cls, func: Callable[[], TResult], when: Literal["collect", "setup", "call", "teardown"], reraise: Optional[ Union[Type[BaseException], Tuple[Type[BaseException], ...]] ] = None, ) -> "CallInfo[TResult]": """Call func, wrapping the result in a CallInfo. :param func: The function to call. Called without arguments. :param when: The phase in which the function is called. :param reraise: Exception or exceptions that shall propagate if raised by the function, instead of being wrapped in the CallInfo. """ excinfo = None start = timing.time() precise_start = timing.perf_counter() try: > result: Optional[TResult] = func() cls = duration = 0.04389314400032163 excinfo = \n') tblen=11> func = . at 0x7ff60b4b3d90> precise_start = 1347323.769599469 precise_stop = 1347323.813492613 reraise = (, ) result = None start = 1714128209.7056832 stop = 1714128209.7495778 when = 'call' /usr/lib/python3.10/site-packages/_pytest/runner.py:340: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ /usr/lib/python3.10/site-packages/_pytest/runner.py:240: in lambda: runtest_hook(item=item, **kwds), when=when, reraise=reraise item = kwds = {} runtest_hook = /usr/lib/python3.10/site-packages/pluggy/_hooks.py:501: in __call__ return self._hookexec(self.name, self._hookimpls.copy(), kwargs, firstresult) firstresult = False kwargs = {'item': } self = /usr/lib/python3.10/site-packages/pluggy/_manager.py:119: in _hookexec return self._inner_hookexec(hook_name, methods, kwargs, firstresult) firstresult = False hook_name = 'pytest_runtest_call' kwargs = {'item': } methods = [>] self = <_pytest.config.PytestPluginManager object at 0x7ff610153df0> /usr/lib/python3.10/site-packages/_pytest/threadexception.py:87: in pytest_runtest_call yield from thread_exception_runtest_hook() /usr/lib/python3.10/site-packages/_pytest/threadexception.py:63: in thread_exception_runtest_hook yield cm = <_pytest.threadexception.catch_threading_exception object at 0x7ff60bfefc70> /usr/lib/python3.10/site-packages/_pytest/unraisableexception.py:90: in pytest_runtest_call yield from unraisable_exception_runtest_hook() _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ def unraisable_exception_runtest_hook() -> Generator[None, None, None]: with catch_unraisable_exception() as cm: try: yield finally: if cm.unraisable: if cm.unraisable.err_msg is not None: err_msg = cm.unraisable.err_msg else: err_msg = "Exception ignored in" msg = f"{err_msg}: {cm.unraisable.object!r}\n\n" msg += "".join( traceback.format_exception( cm.unraisable.exc_type, cm.unraisable.exc_value, cm.unraisable.exc_traceback, ) ) > warnings.warn(pytest.PytestUnraisableExceptionWarning(msg)) E pytest.PytestUnraisableExceptionWarning: Exception ignored in: E E Traceback (most recent call last): E File "/home/tkloczko/rpmbuild/BUILDROOT/python-aiohttp-3.9.5-2.fc37.x86_64/usr/lib64/python3.10/site-packages/aiohttp/test_utils.py", line 537, in teardown_test_loop E gc.collect() E ResourceWarning: unclosed cm = <_pytest.unraisableexception.catch_unraisable_exception object at 0x7ff60bfefc10> err_msg = 'Exception ignored in' msg = 'Exception ignored in: \n\nTr...nResourceWarning: unclosed \n' /usr/lib/python3.10/site-packages/_pytest/unraisableexception.py:80: PytestUnraisableExceptionWarning _____________________________________________________________________________________ test_import_time ______________________________________________________________________________________ pytester = @pytest.mark.internal @pytest.mark.skipif( not sys.platform.startswith("linux") or platform.python_implementation() == "PyPy", reason="Timing is more reliable on Linux", ) def test_import_time(pytester: pytest.Pytester) -> None: """Check that importing aiohttp doesn't take too long. Obviously, the time may vary on different machines and may need to be adjusted from time to time, but this should provide an early warning if something is added that significantly increases import time. """ root = Path(__file__).parent.parent old_path = os.environ.get("PYTHONPATH") os.environ["PYTHONPATH"] = os.pathsep.join([str(root)] + sys.path) best_time_ms = 1000 cmd = "import timeit; print(int(timeit.timeit('import aiohttp', number=1) * 1000))" try: for _ in range(3): r = pytester.run(sys.executable, "-We", "-c", cmd) assert not r.stderr.str() runtime_ms = int(r.stdout.str()) if runtime_ms < best_time_ms: best_time_ms = runtime_ms finally: if old_path is None: os.environ.pop("PYTHONPATH") else: os.environ["PYTHONPATH"] = old_path expected_time = _TARGET_TIMINGS_BY_PYTHON_VERSION.get( f"{sys.version_info.major}.{sys.version_info.minor}", 200 ) > assert best_time_ms < expected_time E assert 214 < 200 _ = 2 best_time_ms = 214 cmd = "import timeit; print(int(timeit.timeit('import aiohttp', number=1) * 1000))" expected_time = 200 old_path = '/home/tkloczko/rpmbuild/BUILDROOT/python-aiohttp-3.9.5-2.fc37.x86_64/usr/lib64/python3.10/site-packages:/home/tkloczko/rpmbuild/BUILDROOT/python-aiohttp-3.9.5-2.fc37.x86_64/usr/lib/python3.10/site-packages' pytester = r = root = PosixPath('/home/tkloczko/rpmbuild/BUILD/aiohttp-3.9.5') runtime_ms = 214 /home/tkloczko/rpmbuild/BUILD/aiohttp-3.9.5/tests/test_imports.py:71: AssertionError ----------------------------------------------------------------------------------- Captured stdout call ------------------------------------------------------------------------------------ running: /usr/bin/python3 -We -c import timeit; print(int(timeit.timeit('import aiohttp', number=1) * 1000)) in: /tmp/pytest-of-tkloczko/pytest-80/test_import_time0 225 running: /usr/bin/python3 -We -c import timeit; print(int(timeit.timeit('import aiohttp', number=1) * 1000)) in: /tmp/pytest-of-tkloczko/pytest-80/test_import_time0 215 running: /usr/bin/python3 -We -c import timeit; print(int(timeit.timeit('import aiohttp', number=1) * 1000)) in: /tmp/pytest-of-tkloczko/pytest-80/test_import_time0 214 ____________________________________________________________________________________ test_aiohttp_plugin ____________________________________________________________________________________ testdir = def test_aiohttp_plugin(testdir) -> None: testdir.makepyfile( """\ import pytest from unittest import mock from aiohttp import web async def hello(request): return web.Response(body=b'Hello, world') def create_app(loop=None): app = web.Application() app.router.add_route('GET', '/', hello) return app async def test_hello(aiohttp_client) -> None: client = await aiohttp_client(create_app) resp = await client.get('/') assert resp.status == 200 text = await resp.text() assert 'Hello, world' in text async def test_hello_from_app(aiohttp_client, loop) -> None: app = web.Application() app.router.add_get('/', hello) client = await aiohttp_client(app) resp = await client.get('/') assert resp.status == 200 text = await resp.text() assert 'Hello, world' in text async def test_hello_with_loop(aiohttp_client, loop) -> None: client = await aiohttp_client(create_app) resp = await client.get('/') assert resp.status == 200 text = await resp.text() assert 'Hello, world' in text async def test_set_args(aiohttp_client, loop) -> None: with pytest.raises(AssertionError): app = web.Application() await aiohttp_client(app, 1, 2, 3) async def test_set_keyword_args(aiohttp_client, loop) -> None: app = web.Application() with pytest.raises(TypeError): await aiohttp_client(app, param=1) async def test_noop() -> None: pass async def previous(request): if request.method == 'POST': with pytest.deprecated_call(): # FIXME: this isn't actually called request.app['value'] = (await request.post())['value'] return web.Response(body=b'thanks for the data') else: v = request.app.get('value', 'unknown') return web.Response(body='value: {}'.format(v).encode()) def create_stateful_app(loop): app = web.Application() app.router.add_route('*', '/', previous) return app @pytest.fixture def cli(loop, aiohttp_client): return loop.run_until_complete(aiohttp_client(create_stateful_app)) async def test_set_value(cli) -> None: resp = await cli.post('/', data={'value': 'foo'}) assert resp.status == 200 text = await resp.text() assert text == 'thanks for the data' assert cli.server.app['value'] == 'foo' async def test_get_value(cli) -> None: resp = await cli.get('/') assert resp.status == 200 text = await resp.text() assert text == 'value: unknown' with pytest.warns(DeprecationWarning): cli.server.app['value'] = 'bar' resp = await cli.get('/') assert resp.status == 200 text = await resp.text() assert text == 'value: bar' def test_noncoro() -> None: assert True async def test_failed_to_create_client(aiohttp_client) -> None: def make_app(loop): raise RuntimeError() with pytest.raises(RuntimeError): await aiohttp_client(make_app) async def test_custom_port_aiohttp_client(aiohttp_client, aiohttp_unused_port): port = aiohttp_unused_port() client = await aiohttp_client(create_app, server_kwargs={'port': port}) assert client.port == port resp = await client.get('/') assert resp.status == 200 text = await resp.text() assert 'Hello, world' in text async def test_custom_port_test_server(aiohttp_server, aiohttp_unused_port): app = create_app() port = aiohttp_unused_port() server = await aiohttp_server(app, port=port) assert server.port == port """ ) testdir.makeconftest(CONFTEST) result = testdir.runpytest("-p", "no:sugar", "--aiohttp-loop=pyloop") > result.assert_outcomes(passed=12) E AssertionError: assert {'errors': 0,...pped': 0, ...} == {'errors': 0,...pped': 0, ...} E E Omitting 4 identical items, use -vv to show E Differing items: E {'passed': 10} != {'passed': 12} E {'failed': 2} != {'failed': 0} E Use -v to get more diff result = testdir = /home/tkloczko/rpmbuild/BUILD/aiohttp-3.9.5/tests/test_pytest_plugin.py:150: AssertionError ----------------------------------------------------------------------------------- Captured stdout call ------------------------------------------------------------------------------------ ============================= test session starts ============================== platform linux -- Python 3.10.14, pytest-8.1.1, pluggy-1.4.0 rootdir: /tmp/pytest-of-tkloczko/pytest-80/test_aiohttp_plugin0 plugins: mock-3.14.0 collected 12 items test_aiohttp_plugin.py ......FF.... [100%] =================================== FAILURES =================================== ____________________________ test_set_value[pyloop] ____________________________ cli = async def test_set_value(cli) -> None: resp = await cli.post('/', data={'value': 'foo'}) > assert resp.status == 200 E AssertionError: assert 500 == 200 E + where 500 = \n\n.status test_aiohttp_plugin.py:82: AssertionError ------------------------------ Captured log call ------------------------------- ERROR aiohttp.server:web_protocol.py:421 Error handling request Traceback (most recent call last): File "/home/tkloczko/rpmbuild/BUILDROOT/python-aiohttp-3.9.5-2.fc37.x86_64/usr/lib64/python3.10/site-packages/aiohttp/web_protocol.py", line 452, in _handle_request resp = await request_handler(request) File "/home/tkloczko/rpmbuild/BUILDROOT/python-aiohttp-3.9.5-2.fc37.x86_64/usr/lib64/python3.10/site-packages/aiohttp/web_app.py", line 543, in _handle resp = await handler(request) File "/tmp/pytest-of-tkloczko/pytest-80/test_aiohttp_plugin0/test_aiohttp_plugin.py", line 61, in previous with pytest.deprecated_call(): # FIXME: this isn't actually called File "/usr/lib/python3.10/site-packages/_pytest/recwarn.py", line 336, in __exit__ warnings.warn_explicit( aiohttp.web_exceptions.NotAppKeyWarning: It is recommended to use web.AppKey instances for keys. https://docs.aiohttp.org/en/stable/web_advanced.html#application-s-config ____________________________ test_get_value[pyloop] ____________________________ cli = async def test_get_value(cli) -> None: resp = await cli.get('/') assert resp.status == 200 text = await resp.text() assert text == 'value: unknown' > with pytest.warns(DeprecationWarning): E aiohttp.web_exceptions.NotAppKeyWarning: It is recommended to use web.AppKey instances for keys. E https://docs.aiohttp.org/en/stable/web_advanced.html#application-s-config test_aiohttp_plugin.py:93: NotAppKeyWarning =========================== short test summary info ============================ FAILED test_aiohttp_plugin.py::test_set_value[pyloop] - AssertionError: asser... FAILED test_aiohttp_plugin.py::test_get_value[pyloop] - aiohttp.web_exception... ========================= 2 failed, 10 passed in 0.53s ========================= ------------------------------------------------------------------------------------- Captured log call ------------------------------------------------------------------------------------- ERROR aiohttp.server:web_protocol.py:421 Error handling request Traceback (most recent call last): File "/home/tkloczko/rpmbuild/BUILDROOT/python-aiohttp-3.9.5-2.fc37.x86_64/usr/lib64/python3.10/site-packages/aiohttp/web_protocol.py", line 452, in _handle_request resp = await request_handler(request) File "/home/tkloczko/rpmbuild/BUILDROOT/python-aiohttp-3.9.5-2.fc37.x86_64/usr/lib64/python3.10/site-packages/aiohttp/web_app.py", line 543, in _handle resp = await handler(request) File "/tmp/pytest-of-tkloczko/pytest-80/test_aiohttp_plugin0/test_aiohttp_plugin.py", line 61, in previous with pytest.deprecated_call(): # FIXME: this isn't actually called File "/usr/lib/python3.10/site-packages/_pytest/recwarn.py", line 336, in __exit__ warnings.warn_explicit( aiohttp.web_exceptions.NotAppKeyWarning: It is recommended to use web.AppKey instances for keys. https://docs.aiohttp.org/en/stable/web_advanced.html#application-s-config __________________________________________________________________________________ test_send_compress_text __________________________________________________________________________________ self = , args = (b'\xc1\x05*\x01b\x00\x00',), kwargs = {}, expected = call(b'\xc1\x05*\x01b\x00\x00'), actual = call(b'\xc1\x04\x02a\x00\x00') _error_message = ._error_message at 0x7ff60a2b7f40>, cause = None def assert_called_with(self, /, *args, **kwargs): """assert that the last call was made with the specified arguments. Raises an AssertionError if the args and keyword args passed in are different to the last call to the mock.""" if self.call_args is None: expected = self._format_mock_call_signature(args, kwargs) actual = 'not called.' error_message = ('expected call not found.\nExpected: %s\nActual: %s' % (expected, actual)) raise AssertionError(error_message) def _error_message(): msg = self._format_mock_failure_message(args, kwargs) return msg expected = self._call_matcher(_Call((args, kwargs), two=True)) actual = self._call_matcher(self.call_args) if actual != expected: cause = expected if isinstance(expected, Exception) else None > raise AssertionError(_error_message()) from cause E AssertionError: expected call not found. E Expected: write(b'\xc1\x05*\x01b\x00\x00') E Actual: write(b'\xc1\x04\x02a\x00\x00') _error_message = ._error_message at 0x7ff60a2b7f40> actual = call(b'\xc1\x04\x02a\x00\x00') args = (b'\xc1\x05*\x01b\x00\x00',) cause = None expected = call(b'\xc1\x05*\x01b\x00\x00') kwargs = {} self = /usr/lib64/python3.10/unittest/mock.py:929: AssertionError During handling of the above exception, another exception occurred: protocol = , transport = async def test_send_compress_text(protocol, transport) -> None: writer = WebSocketWriter(protocol, transport, compress=15) await writer.send(b"text") writer.transport.write.assert_called_with(b"\xc1\x06*I\xad(\x01\x00") await writer.send(b"text") > writer.transport.write.assert_called_with(b"\xc1\x05*\x01b\x00\x00") E AssertionError: expected call not found. E Expected: write(b'\xc1\x05*\x01b\x00\x00') E Actual: write(b'\xc1\x04\x02a\x00\x00') E E pytest introspection follows: E E Args: E assert (b'\xc1\x04\x02a\x00\x00',) == (b'\xc1\x05*\x01b\x00\x00',) E E At index 0 diff: b'\xc1\x04\x02a\x00\x00' != b'\xc1\x05*\x01b\x00\x00' E Use -v to get more diff protocol = transport = writer = tests/test_websocket_writer.py:91: AssertionError ____________________________________________________________________________ test_send_compress_text_notakeover _____________________________________________________________________________ cls = , func = . at 0x7ff60a2b7130>, when = 'call' reraise = (, ) @classmethod def from_call( cls, func: Callable[[], TResult], when: Literal["collect", "setup", "call", "teardown"], reraise: Optional[ Union[Type[BaseException], Tuple[Type[BaseException], ...]] ] = None, ) -> "CallInfo[TResult]": """Call func, wrapping the result in a CallInfo. :param func: The function to call. Called without arguments. :param when: The phase in which the function is called. :param reraise: Exception or exceptions that shall propagate if raised by the function, instead of being wrapped in the CallInfo. """ excinfo = None start = timing.time() precise_start = timing.perf_counter() try: > result: Optional[TResult] = func() cls = duration = 0.05476351408287883 excinfo = \n') tblen=11> func = . at 0x7ff60a2b7130> precise_start = 1347438.142976496 precise_stop = 1347438.19774001 reraise = (, ) result = None start = 1714128324.0790603 stop = 1714128324.1338255 when = 'call' /usr/lib/python3.10/site-packages/_pytest/runner.py:340: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ /usr/lib/python3.10/site-packages/_pytest/runner.py:240: in lambda: runtest_hook(item=item, **kwds), when=when, reraise=reraise item = kwds = {} runtest_hook = /usr/lib/python3.10/site-packages/pluggy/_hooks.py:501: in __call__ return self._hookexec(self.name, self._hookimpls.copy(), kwargs, firstresult) firstresult = False kwargs = {'item': } self = /usr/lib/python3.10/site-packages/pluggy/_manager.py:119: in _hookexec return self._inner_hookexec(hook_name, methods, kwargs, firstresult) firstresult = False hook_name = 'pytest_runtest_call' kwargs = {'item': } methods = [>] self = <_pytest.config.PytestPluginManager object at 0x7ff610153df0> /usr/lib/python3.10/site-packages/_pytest/threadexception.py:87: in pytest_runtest_call yield from thread_exception_runtest_hook() /usr/lib/python3.10/site-packages/_pytest/threadexception.py:63: in thread_exception_runtest_hook yield cm = <_pytest.threadexception.catch_threading_exception object at 0x7ff60cedf670> /usr/lib/python3.10/site-packages/_pytest/unraisableexception.py:90: in pytest_runtest_call yield from unraisable_exception_runtest_hook() _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ def unraisable_exception_runtest_hook() -> Generator[None, None, None]: with catch_unraisable_exception() as cm: try: yield finally: if cm.unraisable: if cm.unraisable.err_msg is not None: err_msg = cm.unraisable.err_msg else: err_msg = "Exception ignored in" msg = f"{err_msg}: {cm.unraisable.object!r}\n\n" msg += "".join( traceback.format_exception( cm.unraisable.exc_type, cm.unraisable.exc_value, cm.unraisable.exc_traceback, ) ) > warnings.warn(pytest.PytestUnraisableExceptionWarning(msg)) E pytest.PytestUnraisableExceptionWarning: Exception ignored in: E E Traceback (most recent call last): E File "/home/tkloczko/rpmbuild/BUILDROOT/python-aiohttp-3.9.5-2.fc37.x86_64/usr/lib64/python3.10/site-packages/aiohttp/test_utils.py", line 537, in teardown_test_loop E gc.collect() E ResourceWarning: unclosed cm = <_pytest.unraisableexception.catch_unraisable_exception object at 0x7ff60cede140> err_msg = 'Exception ignored in' msg = 'Exception ignored in: \n\nTr...nResourceWarning: unclosed \n' /usr/lib/python3.10/site-packages/_pytest/unraisableexception.py:80: PytestUnraisableExceptionWarning ========================================================================================= XFAILURES ========================================================================================= ______________________________________________________________________________ test_broken_connection[pyloop] _______________________________________________________________________________ aiohttp_client = .go at 0x7ff60e56e710> @pytest.mark.xfail async def test_broken_connection(aiohttp_client) -> None: async def handler(request): request.transport.close() return web.Response(text="answer" * 1000) app = web.Application() app.router.add_get("/", handler) client = await aiohttp_client(app) with pytest.raises(aiohttp.ClientResponseError): > await client.get("/") aiohttp_client = .go at 0x7ff60e56e710> app = client = handler = .handler at 0x7ff60dd92b00> tests/test_client_functional.py:2316: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ ../../BUILDROOT/python-aiohttp-3.9.5-2.fc37.x86_64/usr/lib64/python3.10/site-packages/aiohttp/test_utils.py:322: in _request resp = await self._session.request(method, self.make_url(path), **kwargs) kwargs = {} method = 'GET' path = '/' self = ../../BUILDROOT/python-aiohttp-3.9.5-2.fc37.x86_64/usr/lib64/python3.10/site-packages/aiohttp/client.py:608: in _request await resp.start(conn) all_cookies = allow_redirects = True auth = None auth_from_url = None auto_decompress = True chunked = None compress = None conn = Connection cookies = None data = None expect100 = False fingerprint = None handle = None headers = history = [] json = None max_field_size = 8190 max_line_size = 8190 max_redirects = 10 method = 'GET' params = {} proxy = None proxy_auth = None proxy_headers = raise_for_status = None read_bufsize = 65536 read_until_eof = True real_timeout = ClientTimeout(total=300, connect=None, sock_read=None, sock_connect=None, ceil_threshold=5) redirects = 0 req = resp = None self = server_hostname = None skip_auto_headers = None skip_headers = set() ssl = True ssl_context = None str_or_url = URL('http://127.0.0.1:40125/') timeout = <_SENTINEL.sentinel: 1> timer = tm = trace_request_ctx = None traces = [] url = URL('http://127.0.0.1:40125/') verify_ssl = None version = HttpVersion(major=1, minor=1) ../../BUILDROOT/python-aiohttp-3.9.5-2.fc37.x86_64/usr/lib64/python3.10/site-packages/aiohttp/client_reqrep.py:976: in start message, payload = await protocol.read() # type: ignore[union-attr] connection = Connection protocol = self = None _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ self = async def read(self) -> _T: if not self._buffer and not self._eof: assert not self._waiter self._waiter = self._loop.create_future() try: > await self._waiter E aiohttp.client_exceptions.ServerDisconnectedError: Server disconnected self = ../../BUILDROOT/python-aiohttp-3.9.5-2.fc37.x86_64/usr/lib64/python3.10/site-packages/aiohttp/streams.py:640: ServerDisconnectedError _______________________________________________________________________________ test_rejected_upload[pyloop] ________________________________________________________________________________ aiohttp_client = .go at 0x7ff60e56e680>, tmp_path = PosixPath('/tmp/pytest-of-tkloczko/pytest-80/test_rejected_upload_pyloop_0') @pytest.mark.xfail(raises=asyncio.TimeoutError, reason="#7599") async def test_rejected_upload(aiohttp_client, tmp_path) -> None: async def ok_handler(request): return web.Response() async def not_ok_handler(request): raise web.HTTPBadRequest() app = web.Application() app.router.add_get("/ok", ok_handler) app.router.add_post("/not_ok", not_ok_handler) client = await aiohttp_client(app) file_size_bytes = 1024 * 1024 file_path = tmp_path / "uploaded.txt" file_path.write_text("0" * file_size_bytes, encoding="utf8") with open(file_path, "rb") as file: data = {"file": file} async with await client.post("/not_ok", data=data) as resp_not_ok: assert 400 == resp_not_ok.status > async with await client.get( "/ok", timeout=aiohttp.ClientTimeout(total=0.01) ) as resp_ok: aiohttp_client = .go at 0x7ff60e56e680> app = client = data = {'file': <_io.BufferedReader name='/tmp/pytest-of-tkloczko/pytest-80/test_rejected_upload_pyloop_0/uploaded.txt'>} file = <_io.BufferedReader name='/tmp/pytest-of-tkloczko/pytest-80/test_rejected_upload_pyloop_0/uploaded.txt'> file_path = PosixPath('/tmp/pytest-of-tkloczko/pytest-80/test_rejected_upload_pyloop_0/uploaded.txt') file_size_bytes = 1048576 not_ok_handler = .not_ok_handler at 0x7ff60b4b1b40> ok_handler = .ok_handler at 0x7ff60cc5e290> resp_not_ok =

tmp_path = PosixPath('/tmp/pytest-of-tkloczko/pytest-80/test_rejected_upload_pyloop_0') tests/test_client_functional.py:3412: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ ../../BUILDROOT/python-aiohttp-3.9.5-2.fc37.x86_64/usr/lib64/python3.10/site-packages/aiohttp/test_utils.py:322: in _request resp = await self._session.request(method, self.make_url(path), **kwargs) kwargs = {'timeout': ClientTimeout(total=0.01, connect=None, sock_read=None, sock_connect=None, ceil_threshold=5)} method = 'GET' path = '/ok' self = ../../BUILDROOT/python-aiohttp-3.9.5-2.fc37.x86_64/usr/lib64/python3.10/site-packages/aiohttp/client.py:608: in _request await resp.start(conn) all_cookies = allow_redirects = True auth = None auth_from_url = None auto_decompress = True chunked = None compress = None conn = Connection cookies = None data = None expect100 = False fingerprint = None handle = None headers = history = [] json = None max_field_size = 8190 max_line_size = 8190 max_redirects = 10 method = 'GET' params = {} proxy = None proxy_auth = None proxy_headers = raise_for_status = None read_bufsize = 65536 read_until_eof = True real_timeout = ClientTimeout(total=0.01, connect=None, sock_read=None, sock_connect=None, ceil_threshold=5) redirects = 0 req = resp = None self = server_hostname = None skip_auto_headers = None skip_headers = set() ssl = True ssl_context = None str_or_url = URL('http://127.0.0.1:39305/ok') timeout = ClientTimeout(total=0.01, connect=None, sock_read=None, sock_connect=None, ceil_threshold=5) timer = tm = trace_request_ctx = None traces = [] url = URL('http://127.0.0.1:39305/ok') verify_ssl = None version = HttpVersion(major=1, minor=1) ../../BUILDROOT/python-aiohttp-3.9.5-2.fc37.x86_64/usr/lib64/python3.10/site-packages/aiohttp/client_reqrep.py:971: in start with self._timer: connection = Connection protocol = self = None _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ self = , exc_type = , exc_val = CancelledError() exc_tb = def __exit__( self, exc_type: Optional[Type[BaseException]], exc_val: Optional[BaseException], exc_tb: Optional[TracebackType], ) -> Optional[bool]: if self._tasks: self._tasks.pop() if exc_type is asyncio.CancelledError and self._cancelled: > raise asyncio.TimeoutError from None E asyncio.exceptions.TimeoutError exc_tb = exc_type = exc_val = CancelledError() self = ../../BUILDROOT/python-aiohttp-3.9.5-2.fc37.x86_64/usr/lib64/python3.10/site-packages/aiohttp/helpers.py:735: TimeoutError __________________________________________________________________________ test_del_with_scheduled_cleanup[pyloop] __________________________________________________________________________ self = , args = (<_UnixSelectorEventLoop running=False closed=False debug=True>, {'connector': , 'message': 'Unclosed connector', 'source_traceback': }) kwargs = {}, expected = call(<_UnixSelectorEventLoop running=False closed=False debug=True>, {'connector': , 'message': 'Unclosed connector', 'source_traceback': }) actual = call(<_UnixSelectorEventLoop running=False closed=False debug=True>, {'connector': ]}) _error_message = ._error_message at 0x7ff60b4b3d90>, cause = None def assert_called_with(self, /, *args, **kwargs): """assert that the last call was made with the specified arguments. Raises an AssertionError if the args and keyword args passed in are different to the last call to the mock.""" if self.call_args is None: expected = self._format_mock_call_signature(args, kwargs) actual = 'not called.' error_message = ('expected call not found.\nExpected: %s\nActual: %s' % (expected, actual)) raise AssertionError(error_message) def _error_message(): msg = self._format_mock_failure_message(args, kwargs) return msg expected = self._call_matcher(_Call((args, kwargs), two=True)) actual = self._call_matcher(self.call_args) if actual != expected: cause = expected if isinstance(expected, Exception) else None > raise AssertionError(_error_message()) from cause E AssertionError: expected call not found. E Expected: mock(<_UnixSelectorEventLoop running=True closed=False debug=True>, {'connector': , 'message': 'Unclosed connector', 'source_traceback': }) E Actual: mock(<_UnixSelectorEventLoop running=True closed=False debug=True>, {'connector': , 'connections': ["[(, 123)]"], 'message': 'Unclosed connector', 'source_traceback': [>, , , , , , , , , , , , , , , , , , , , >, , , , , , , , , , , , , , ]}) _error_message = ._error_message at 0x7ff60b4b3d90> actual = call(<_UnixSelectorEventLoop running=False closed=False debug=True>, {'connector': ]}) args = (<_UnixSelectorEventLoop running=False closed=False debug=True>, {'connector': , 'message': 'Unclosed connector', 'source_traceback': }) cause = None expected = call(<_UnixSelectorEventLoop running=False closed=False debug=True>, {'connector': , 'message': 'Unclosed connector', 'source_traceback': }) kwargs = {} self = /usr/lib64/python3.10/unittest/mock.py:929: AssertionError During handling of the above exception, another exception occurred: loop = <_UnixSelectorEventLoop running=False closed=False debug=True> @pytest.mark.xfail async def test_del_with_scheduled_cleanup(loop) -> None: loop.set_debug(True) conn = aiohttp.BaseConnector(loop=loop, keepalive_timeout=0.01) transp = mock.Mock() conn._conns["a"] = [(transp, 123)] conns_impl = conn._conns exc_handler = mock.Mock() loop.set_exception_handler(exc_handler) with pytest.warns(ResourceWarning): # obviously doesn't deletion because loop has a strong # reference to connector's instance method, isn't it? del conn await asyncio.sleep(0.01) gc.collect() assert not conns_impl transp.close.assert_called_with() msg = {"connector": mock.ANY, "message": "Unclosed connector"} # conn was deleted if loop.get_debug(): msg["source_traceback"] = mock.ANY > exc_handler.assert_called_with(loop, msg) E AssertionError: expected call not found. E Expected: mock(<_UnixSelectorEventLoop running=True closed=False debug=True>, {'connector': , 'message': 'Unclosed connector', 'source_traceback': }) E Actual: mock(<_UnixSelectorEventLoop running=True closed=False debug=True>, {'connector': , 'connections': ["[(, 123)]"], 'message': 'Unclosed connector', 'source_traceback': [>, , , , , , , , , , , , , , , , , , , , >, , , , , , , , , , , , , , ]}) E E pytest introspection follows: E E Args: E assert (<_UnixSelect...ed_cleanup>]}) == (<_UnixSelect...back': }) E E At index 1 diff: {'connector': , 'connections': ["[(, 123)]"], 'message': 'Unclosed connector', 'source_traceback'... E E ...Full output truncated (2 lines hidden), use '-vv' to show conns_impl = {} exc_handler = loop = <_UnixSelectorEventLoop running=False closed=False debug=True> msg = {'connector': , 'message': 'Unclosed connector', 'source_traceback': } transp = tests/test_connector.py:200: AssertionError ------------------------------------------------------------------------------------- Captured log call ------------------------------------------------------------------------------------- WARNING asyncio:base_events.py:1904 Executing exception=AssertionError('expected call not found.\nExpected: mock(<_UnixSelectorEventLoop running=True closed=False debug=True>, {\'connector\': , \'message\': \'Unclosed connector\', \'source_traceback\': })\nActual: mock(<_UnixSelectorEventLoop running=True closed=False debug=True>, {\'connector\': , \'connections\': ["[(, 123)]"], \'message\': \'Unclosed connector\', \'source_traceback\': [>, , , , , , , , , , , , , , , , , , , , >, , , , , , , , , , , , , , ]})\n\npytest introspection follows:\n\nArgs:\nassert (<_UnixSelect...ed_cleanup>]}) == (<_UnixSelect...back\': })\n \n At index 1 diff: \x1b[0m{\x1b[33m\'\x1b[39;49;00m\x1b[33mconnector\x1b[39;49;00m\x1b[33m\'\x1b[39;49;00m: , \x1b[33m\'\x1b[39;49;00m\x1b[33mconnections\x1b[39;49;00m\x1b[33m\'\x1b[39;49;00m: [\x1b[33m"\x1b[39;49;00m\x1b[33m[(, 123)]\x1b[39;49;00m\x1b[33m"\x1b[39;49;00m], \x1b[33m\'\x1b[39;49;00m\x1b[33mmessage\x1b[39;49;00m\x1b[33m\'\x1b[39;49;00m: \x1b[33m\'\x1b[39;49;00m\x1b[33mUnclosed connector\x1b[39;49;00m\x1b[33m\'\x1b[39;49;00m, \x1b[33m\'\x1b[39;49;00m\x1b[33msource_traceback\x1b[39;49;00m\x1b[33m\'...\n \n ...Full output truncated (2 lines hidden), use \'-vv\' to show')> took 0.110 seconds _____________________________________________________________________ test_parse_unusual_request_line[py-parser-pyloop] _____________________________________________________________________ parser = def test_parse_unusual_request_line(parser) -> None: if not isinstance(response, HttpResponseParserPy): > pytest.xfail("Regression test for Py parser. May match C behaviour later.") E _pytest.outcomes.XFailed: Regression test for Py parser. May match C behaviour later. parser = tests/test_http_parser.py:299: XFailed _____________________________________________________________________ test_parse_unusual_request_line[c-parser-pyloop] ______________________________________________________________________ parser = def test_parse_unusual_request_line(parser) -> None: if not isinstance(response, HttpResponseParserPy): > pytest.xfail("Regression test for Py parser. May match C behaviour later.") E _pytest.outcomes.XFailed: Regression test for Py parser. May match C behaviour later. parser = tests/test_http_parser.py:299: XFailed _______________________________________________________ test_invalid_header_spacing[py-parser-pyloop-pre-empty-post-empty-name-empty] _______________________________________________________ parser = , pad1 = b'', pad2 = b'', hdr = b'' @pytest.mark.parametrize("hdr", [b"", b"foo"], ids=["name-empty", "with-name"]) @pytest.mark.parametrize("pad2", _pad.keys(), ids=["post-" + n for n in _pad.values()]) @pytest.mark.parametrize("pad1", _pad.keys(), ids=["pre-" + n for n in _pad.values()]) def test_invalid_header_spacing(parser, pad1: bytes, pad2: bytes, hdr: bytes) -> None: text = b"GET /test HTTP/1.1\r\n" b"%s%s%s: value\r\n\r\n" % (pad1, hdr, pad2) expectation = pytest.raises(http_exceptions.BadHttpMessage) if pad1 == pad2 == b"" and hdr != b"": # one entry in param matrix is correct: non-empty name, not padded expectation = nullcontext() if pad1 == pad2 == hdr == b"": if not isinstance(response, HttpResponseParserPy): > pytest.xfail("Regression test for Py parser. May match C behaviour later.") E _pytest.outcomes.XFailed: Regression test for Py parser. May match C behaviour later. expectation = <_pytest.python_api.RaisesContext object at 0x7ff60dea3fd0> hdr = b'' pad1 = b'' pad2 = b'' parser = text = b'GET /test HTTP/1.1\r\n: value\r\n\r\n' tests/test_http_parser.py:637: XFailed _______________________________________________________ test_invalid_header_spacing[c-parser-pyloop-pre-empty-post-empty-name-empty] ________________________________________________________ parser = , pad1 = b'', pad2 = b'', hdr = b'' @pytest.mark.parametrize("hdr", [b"", b"foo"], ids=["name-empty", "with-name"]) @pytest.mark.parametrize("pad2", _pad.keys(), ids=["post-" + n for n in _pad.values()]) @pytest.mark.parametrize("pad1", _pad.keys(), ids=["pre-" + n for n in _pad.values()]) def test_invalid_header_spacing(parser, pad1: bytes, pad2: bytes, hdr: bytes) -> None: text = b"GET /test HTTP/1.1\r\n" b"%s%s%s: value\r\n\r\n" % (pad1, hdr, pad2) expectation = pytest.raises(http_exceptions.BadHttpMessage) if pad1 == pad2 == b"" and hdr != b"": # one entry in param matrix is correct: non-empty name, not padded expectation = nullcontext() if pad1 == pad2 == hdr == b"": if not isinstance(response, HttpResponseParserPy): > pytest.xfail("Regression test for Py parser. May match C behaviour later.") E _pytest.outcomes.XFailed: Regression test for Py parser. May match C behaviour later. expectation = <_pytest.python_api.RaisesContext object at 0x7ff60cfffc70> hdr = b'' pad1 = b'' pad2 = b'' parser = text = b'GET /test HTTP/1.1\r\n: value\r\n\r\n' tests/test_http_parser.py:637: XFailed _______________________________________________________________ test_http_request_parser_utf8_request_line[py-parser-pyloop] ________________________________________________________________ parser = def test_http_request_parser_utf8_request_line(parser) -> None: if not isinstance(response, HttpResponseParserPy): > pytest.xfail("Regression test for Py parser. May match C behaviour later.") E _pytest.outcomes.XFailed: Regression test for Py parser. May match C behaviour later. parser = tests/test_http_parser.py:820: XFailed ________________________________________________________________ test_http_request_parser_utf8_request_line[c-parser-pyloop] ________________________________________________________________ parser = def test_http_request_parser_utf8_request_line(parser) -> None: if not isinstance(response, HttpResponseParserPy): > pytest.xfail("Regression test for Py parser. May match C behaviour later.") E _pytest.outcomes.XFailed: Regression test for Py parser. May match C behaviour later. parser = tests/test_http_parser.py:820: XFailed ___________________________________________________________________________ test_parse_uri_utf8[c-parser-pyloop] ____________________________________________________________________________ parser = def test_parse_uri_utf8(parser) -> None: if not isinstance(parser, HttpRequestParserPy): > pytest.xfail("Not valid HTTP. Maybe update py-parser to reject later.") E _pytest.outcomes.XFailed: Not valid HTTP. Maybe update py-parser to reject later. parser = tests/test_http_parser.py:1411: XFailed __________________________________________________________________________ test_http10_keep_alive_default[pyloop] ___________________________________________________________________________ aiohttp_client = .go at 0x7ff60af35480> @pytest.mark.xfail async def test_http10_keep_alive_default(aiohttp_client) -> None: async def handler(request): return web.Response() app = web.Application() app.router.add_get("/", handler) client = await aiohttp_client(app, version=HttpVersion10) resp = await client.get("/") assert 200 == resp.status assert resp.version == HttpVersion10 > assert resp.headers["Connection"] == "keep-alive" E KeyError: 'Connection' aiohttp_client = .go at 0x7ff60af35480> app = client = handler = .handler at 0x7ff60b2035b0> resp =

tests/test_web_functional.py:654: KeyError _____________________________________________________________________________ test_unsupported_upgrade[pyloop] ______________________________________________________________________________ aiohttp_raw_server = .go at 0x7ff60ad96f80>, aiohttp_client = .go at 0x7ff60ad97490> @pytest.mark.xfail( not helpers.NO_EXTENSIONS, raises=client.ServerDisconnectedError, reason="The behavior of C-extensions differs from pure-Python: " "https://github.com/aio-libs/aiohttp/issues/6446", ) async def test_unsupported_upgrade(aiohttp_raw_server, aiohttp_client) -> None: # don't fail if a client probes for an unsupported protocol upgrade # https://github.com/aio-libs/aiohttp/issues/6446#issuecomment-999032039 async def handler(request: web.Request): return web.Response(body=await request.read()) upgrade_headers = {"Connection": "Upgrade", "Upgrade": "unsupported_proto"} server = await aiohttp_raw_server(handler) cli = await aiohttp_client(server) test_data = b"Test" > resp = await cli.post("/path/to", data=test_data, headers=upgrade_headers) aiohttp_client = .go at 0x7ff60ad97490> aiohttp_raw_server = .go at 0x7ff60ad96f80> cli = handler = .handler at 0x7ff60ad96e60> server = test_data = b'Test' upgrade_headers = {'Connection': 'Upgrade', 'Upgrade': 'unsupported_proto'} tests/test_web_server.py:38: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ ../../BUILDROOT/python-aiohttp-3.9.5-2.fc37.x86_64/usr/lib64/python3.10/site-packages/aiohttp/test_utils.py:322: in _request resp = await self._session.request(method, self.make_url(path), **kwargs) kwargs = {'data': b'Test', 'headers': {'Connection': 'Upgrade', 'Upgrade': 'unsupported_proto'}} method = 'POST' path = '/path/to' self = ../../BUILDROOT/python-aiohttp-3.9.5-2.fc37.x86_64/usr/lib64/python3.10/site-packages/aiohttp/client.py:608: in _request await resp.start(conn) all_cookies = allow_redirects = True auth = None auth_from_url = None auto_decompress = True chunked = None compress = None conn = Connection cookies = None data = b'Test' expect100 = False fingerprint = None handle = None headers = history = [] json = None max_field_size = 8190 max_line_size = 8190 max_redirects = 10 method = 'POST' params = {} proxy = None proxy_auth = None proxy_headers = raise_for_status = None read_bufsize = 65536 read_until_eof = True real_timeout = ClientTimeout(total=300, connect=None, sock_read=None, sock_connect=None, ceil_threshold=5) redirects = 0 req = resp = None self = server_hostname = None skip_auto_headers = None skip_headers = set() ssl = True ssl_context = None str_or_url = URL('http://127.0.0.1:41173/path/to') timeout = <_SENTINEL.sentinel: 1> timer = tm = trace_request_ctx = None traces = [] url = URL('http://127.0.0.1:41173/path/to') verify_ssl = None version = HttpVersion(major=1, minor=1) ../../BUILDROOT/python-aiohttp-3.9.5-2.fc37.x86_64/usr/lib64/python3.10/site-packages/aiohttp/client_reqrep.py:976: in start message, payload = await protocol.read() # type: ignore[union-attr] connection = Connection protocol = self = None _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ self = async def read(self) -> _T: if not self._buffer and not self._eof: assert not self._waiter self._waiter = self._loop.create_future() try: > await self._waiter E aiohttp.client_exceptions.ServerDisconnectedError: Server disconnected self = ../../BUILDROOT/python-aiohttp-3.9.5-2.fc37.x86_64/usr/lib64/python3.10/site-packages/aiohttp/streams.py:640: ServerDisconnectedError ------------------------------------------------------------------------------------- Captured log call ------------------------------------------------------------------------------------- ERROR aiohttp.server:web_protocol.py:421 Unhandled exception Traceback (most recent call last): File "/home/tkloczko/rpmbuild/BUILDROOT/python-aiohttp-3.9.5-2.fc37.x86_64/usr/lib64/python3.10/site-packages/aiohttp/web_protocol.py", line 531, in start resp, reset = await task File "/home/tkloczko/rpmbuild/BUILDROOT/python-aiohttp-3.9.5-2.fc37.x86_64/usr/lib64/python3.10/site-packages/aiohttp/web_protocol.py", line 477, in _handle_request reset = await self.finish_response(request, resp, start_time) File "/home/tkloczko/rpmbuild/BUILDROOT/python-aiohttp-3.9.5-2.fc37.x86_64/usr/lib64/python3.10/site-packages/aiohttp/web_protocol.py", line 616, in finish_response self._request_parser.feed_data(self._message_tail) File "aiohttp/_http_parser.pyx", line 557, in aiohttp._http_parser.HttpParser.feed_data raise ex aiohttp.http_exceptions.BadStatusLine: 400, message: Invalid method encountered: b'Test' ^ ______________________________________________________________________ test_decoded_url_match[pyloop-urldecoded_route] ______________________________________________________________________ aiohttp_client = .go at 0x7ff60ad97130>, route_definition = '/467,802,24834/hello', urlencoded_path = '/467%2C802%2C24834/hello' expected_http_resp_status = 200 @pytest.mark.xfail( raises=AssertionError, reason="Regression in v3.7: https://github.com/aio-libs/aiohttp/issues/5621", ) @pytest.mark.parametrize( ("route_definition", "urlencoded_path", "expected_http_resp_status"), ( ("/467,802,24834/hello", "/467%2C802%2C24834/hello", 200), ("/{user_ids:([0-9]+)(,([0-9]+))*}/hello", "/467%2C802%2C24834/hello", 200), ("/1%2C3/hello", "/1%2C3/hello", 404), ), ids=("urldecoded_route", "urldecoded_route_with_regex", "urlencoded_route"), ) async def test_decoded_url_match( aiohttp_client: AiohttpClient, route_definition: str, urlencoded_path: str, expected_http_resp_status: int, ) -> None: app = web.Application() async def handler(request: web.Request) -> web.Response: return web.Response() app.router.add_get(route_definition, handler) client = await aiohttp_client(app) r = await client.get(yarl.URL(urlencoded_path, encoded=True)) > assert r.status == expected_http_resp_status E AssertionError: assert 404 == 200 E + where 404 = \n\n.status aiohttp_client = .go at 0x7ff60ad97130> app = client = expected_http_resp_status = 200 handler = .handler at 0x7ff60ad96710> r =

route_definition = '/467,802,24834/hello' urlencoded_path = '/467%2C802%2C24834/hello' tests/test_web_urldispatcher.py:753: AssertionError ________________________________________________________________ test_decoded_url_match[pyloop-urldecoded_route_with_regex] _________________________________________________________________ aiohttp_client = .go at 0x7ff60a2b5900>, route_definition = '/{user_ids:([0-9]+)(,([0-9]+))*}/hello', urlencoded_path = '/467%2C802%2C24834/hello' expected_http_resp_status = 200 @pytest.mark.xfail( raises=AssertionError, reason="Regression in v3.7: https://github.com/aio-libs/aiohttp/issues/5621", ) @pytest.mark.parametrize( ("route_definition", "urlencoded_path", "expected_http_resp_status"), ( ("/467,802,24834/hello", "/467%2C802%2C24834/hello", 200), ("/{user_ids:([0-9]+)(,([0-9]+))*}/hello", "/467%2C802%2C24834/hello", 200), ("/1%2C3/hello", "/1%2C3/hello", 404), ), ids=("urldecoded_route", "urldecoded_route_with_regex", "urlencoded_route"), ) async def test_decoded_url_match( aiohttp_client: AiohttpClient, route_definition: str, urlencoded_path: str, expected_http_resp_status: int, ) -> None: app = web.Application() async def handler(request: web.Request) -> web.Response: return web.Response() app.router.add_get(route_definition, handler) client = await aiohttp_client(app) r = await client.get(yarl.URL(urlencoded_path, encoded=True)) > assert r.status == expected_http_resp_status E AssertionError: assert 404 == 200 E + where 404 = \n\n.status aiohttp_client = .go at 0x7ff60a2b5900> app = client = expected_http_resp_status = 200 handler = .handler at 0x7ff60ad96d40> r =

route_definition = '/{user_ids:([0-9]+)(,([0-9]+))*}/hello' urlencoded_path = '/467%2C802%2C24834/hello' tests/test_web_urldispatcher.py:753: AssertionError ______________________________________________________________________ test_decoded_url_match[pyloop-urlencoded_route] ______________________________________________________________________ aiohttp_client = .go at 0x7ff60a2b5a20>, route_definition = '/1%2C3/hello', urlencoded_path = '/1%2C3/hello', expected_http_resp_status = 404 @pytest.mark.xfail( raises=AssertionError, reason="Regression in v3.7: https://github.com/aio-libs/aiohttp/issues/5621", ) @pytest.mark.parametrize( ("route_definition", "urlencoded_path", "expected_http_resp_status"), ( ("/467,802,24834/hello", "/467%2C802%2C24834/hello", 200), ("/{user_ids:([0-9]+)(,([0-9]+))*}/hello", "/467%2C802%2C24834/hello", 200), ("/1%2C3/hello", "/1%2C3/hello", 404), ), ids=("urldecoded_route", "urldecoded_route_with_regex", "urlencoded_route"), ) async def test_decoded_url_match( aiohttp_client: AiohttpClient, route_definition: str, urlencoded_path: str, expected_http_resp_status: int, ) -> None: app = web.Application() async def handler(request: web.Request) -> web.Response: return web.Response() app.router.add_get(route_definition, handler) client = await aiohttp_client(app) r = await client.get(yarl.URL(urlencoded_path, encoded=True)) > assert r.status == expected_http_resp_status E AssertionError: assert 200 == 404 E + where 200 = \n\n.status aiohttp_client = .go at 0x7ff60a2b5a20> app = client = expected_http_resp_status = 404 handler = .handler at 0x7ff60ad96e60> r =

route_definition = '/1%2C3/hello' urlencoded_path = '/1%2C3/hello' tests/test_web_urldispatcher.py:753: AssertionError =================================================================================== slowest 10 durations ==================================================================================== 9.52s call tests/test_run_app.py::TestShutdown::test_shutdown_new_conn_rejected 4.01s call tests/test_run_app.py::TestShutdown::test_shutdown_pending_handler_responds 2.51s call tests/test_run_app.py::TestShutdown::test_shutdown_wait_for_spawned_task 2.51s call tests/test_run_app.py::TestShutdown::test_shutdown_wait_for_task 2.01s call tests/test_client_functional.py::test_read_timeout_between_chunks[pyloop] 2.00s call tests/test_client_functional.py::test_set_cookies_max_age[pyloop] 1.51s call tests/test_run_app.py::TestShutdown::test_shutdown_timeout_task 1.51s call tests/test_run_app.py::TestShutdown::test_shutdown_timeout_not_reached 1.02s call tests/test_run_app.py::TestShutdown::test_shutdown_close_websockets 1.01s call tests/test_run_app.py::TestShutdown::test_shutdown_close_idle_keepalive ================================================================================== short test summary info ================================================================================== SKIPPED [1] tests/test_client_session.py:781: The check is applied in DEBUG mode only SKIPPED [1] tests/test_connector.py:1972: Proactor Event loop present only in Windows SKIPPED [1] tests/test_connector.py:1980: Proactor Event loop present only in Windows SKIPPED [1] tests/test_connector.py:1991: Proactor Event loop present only in Windows SKIPPED [1] tests/test_connector.py:2174: Proactor Event loop present only in Windows SKIPPED [1] tests/test_multipart_helpers.py:99: need more smart parser which respects quoted text SKIPPED [1] tests/test_multipart_helpers.py:446: should raise decoding error: %82 is invalid for latin1 SKIPPED [1] tests/test_multipart_helpers.py:455: should raise decoding error: %E4 is invalid for utf-8 SKIPPED [1] tests/test_multipart_helpers.py:510: urllib.parse.unquote is tolerate to standalone % chars SKIPPED [1] tests/test_multipart_helpers.py:519: urllib.parse.unquote is tolerate to standalone % chars SKIPPED [2] tests/test_proxy_functional.py:105: asyncio on this python does not support TLS in TLS SKIPPED [1] tests/test_proxy_functional.py:394: we need to reconsider how we test this SKIPPED [1] tests/test_proxy_functional.py:418: we need to reconsider how we test this SKIPPED [1] tests/test_web_app.py:365: The check is applied in DEBUG mode only SKIPPED [1] tests/test_web_runner.py:121: Proactor Event loop present only in Windows SKIPPED [1] tests/test_web_runner.py:131: Proactor Event loop present only in Windows XFAIL tests/test_client_functional.py::test_broken_connection[pyloop] XFAIL tests/test_client_functional.py::test_rejected_upload[pyloop] - #7599 XFAIL tests/test_connector.py::test_del_with_scheduled_cleanup[pyloop] XFAIL tests/test_http_parser.py::test_parse_unusual_request_line[py-parser-pyloop] - reason: Regression test for Py parser. May match C behaviour later. XFAIL tests/test_http_parser.py::test_parse_unusual_request_line[c-parser-pyloop] - reason: Regression test for Py parser. May match C behaviour later. XFAIL tests/test_http_parser.py::test_invalid_header_spacing[py-parser-pyloop-pre-empty-post-empty-name-empty] - reason: Regression test for Py parser. May match C behaviour later. XFAIL tests/test_http_parser.py::test_invalid_header_spacing[c-parser-pyloop-pre-empty-post-empty-name-empty] - reason: Regression test for Py parser. May match C behaviour later. XFAIL tests/test_http_parser.py::test_http_request_parser_utf8_request_line[py-parser-pyloop] - reason: Regression test for Py parser. May match C behaviour later. XFAIL tests/test_http_parser.py::test_http_request_parser_utf8_request_line[c-parser-pyloop] - reason: Regression test for Py parser. May match C behaviour later. XFAIL tests/test_http_parser.py::test_parse_uri_utf8[c-parser-pyloop] - reason: Not valid HTTP. Maybe update py-parser to reject later. XFAIL tests/test_web_functional.py::test_http10_keep_alive_default[pyloop] XFAIL tests/test_web_server.py::test_unsupported_upgrade[pyloop] - The behavior of C-extensions differs from pure-Python: https://github.com/aio-libs/aiohttp/issues/6446 XFAIL tests/test_web_urldispatcher.py::test_decoded_url_match[pyloop-urldecoded_route] - Regression in v3.7: https://github.com/aio-libs/aiohttp/issues/5621 XFAIL tests/test_web_urldispatcher.py::test_decoded_url_match[pyloop-urldecoded_route_with_regex] - Regression in v3.7: https://github.com/aio-libs/aiohttp/issues/5621 XFAIL tests/test_web_urldispatcher.py::test_decoded_url_match[pyloop-urlencoded_route] - Regression in v3.7: https://github.com/aio-libs/aiohttp/issues/5621 FAILED tests/test_client_session.py::test_client_session_timeout_zero - aiohttp.client_exceptions.ClientConnectorError: Cannot connect to host example.com:80 ssl:default [Name or service not known] FAILED tests/test_client_session.py::test_client_session_timeout_bad_argument - pytest.PytestUnraisableExceptionWarning: Exception ignored in: FAILED tests/test_imports.py::test_import_time - assert 214 < 200 FAILED tests/test_pytest_plugin.py::test_aiohttp_plugin - AssertionError: assert {'errors': 0,...pped': 0, ...} == {'errors': 0,...pped': 0, ...} FAILED tests/test_websocket_writer.py::test_send_compress_text - AssertionError: expected call not found. FAILED tests/test_websocket_writer.py::test_send_compress_text_notakeover - pytest.PytestUnraisableExceptionWarning: Exception ignored in: ===================================================== 6 failed, 3076 passed, 17 skipped, 10 deselected, 15 xfailed in 158.43s (0:02:38) ===================================================== ```

aio-libs / aiohttp

3.8.4: pytest is failing in 9 units #7255

Describe the bug

To Reproduce

Expected behavior

Logs/tracebacks

Python Version

aiohttp Version

multidict Version

yarl Version

OS

Related component

Additional context

Code of Conduct

7260