search

aio-libs / aiohttp

Asynchronous HTTP client/server framework for asyncio and Python
https://docs.aiohttp.org
Other
14.97k stars 2k forks source link

missing headers_received signal in TraceConfig #7386

Open HMaker opened 1 year ago

HMaker commented 1 year ago

Is your feature request related to a problem?

aiohttp's client tracing docs state the request flow has a stage named headers_received. I suppose this means response headers received. But TraceConfig has no declared signal handler for it.

Describe the solution you'd like

Tracing when response headers are received is usefull for early request time measuring. A new signal should be added at TraceConfig.on_response_headers_received.

Describe alternatives you've considered

None

Related component

Client

Additional context

No response

Code of Conduct

Hadock-is-ok commented 2 weeks ago

this does exist in aiohttp.tracing (aiohttp.tracing.TraceRequestHeadersSentParams), but was never imported into the main file.

Dreamsorcerer commented 2 weeks ago

I don't think that's on headers received.

Hadock-is-ok commented 2 weeks ago

misread, I retract my comment.