aio-libs / aiokafka

asyncio client for kafka
http://aiokafka.readthedocs.io/
Apache License 2.0
1.08k stars 224 forks source link

change request metadata error to warning #1009

Closed oferda4 closed 1 month ago

oferda4 commented 1 month ago

Changes

Make log of "Unable to request metadata from node" warning instead of error as it's handled. This is the same as in line 246 in the same file. This change will allow to better monitor errors from this lib and distinguish them from warnings.

Checklist

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.04%. Comparing base (c10fed0) to head (7841796).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1009 +/- ## ======================================= Coverage 95.04% 95.04% ======================================= Files 114 114 Lines 16906 16906 Branches 2759 2759 ======================================= Hits 16068 16068 Misses 493 493 Partials 345 345 ``` | [Flag](https://app.codecov.io/gh/aio-libs/aiokafka/pull/1009/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | Coverage Δ | | |---|---|---| | [cext](https://app.codecov.io/gh/aio-libs/aiokafka/pull/1009/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `91.94% <100.00%> (-0.02%)` | :arrow_down: | | [integration](https://app.codecov.io/gh/aio-libs/aiokafka/pull/1009/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `94.69% <100.00%> (ø)` | | | [purepy](https://app.codecov.io/gh/aio-libs/aiokafka/pull/1009/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `94.49% <100.00%> (ø)` | | | [unit](https://app.codecov.io/gh/aio-libs/aiokafka/pull/1009/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `52.72% <0.00%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.