aio-libs / aiokafka

asyncio client for kafka
http://aiokafka.readthedocs.io/
Apache License 2.0
1.08k stars 224 forks source link

add typing to aiokafka/conn.py #1021

Open dimastbk opened 2 days ago

dimastbk commented 2 days ago

Changes

Fixes #

Checklist

codecov[bot] commented 2 days ago

Codecov Report

Attention: Patch coverage is 96.57795% with 9 lines in your changes missing coverage. Please review.

Project coverage is 95.00%. Comparing base (b861a26) to head (2801b29). Report is 2 commits behind head on master.

Files Patch % Lines
aiokafka/conn.py 93.18% 1 Missing and 8 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1021 +/- ## ========================================== - Coverage 95.02% 95.00% -0.02% ========================================== Files 114 114 Lines 16970 17069 +99 Branches 2771 2779 +8 ========================================== + Hits 16125 16216 +91 - Misses 497 498 +1 - Partials 348 355 +7 ``` | [Flag](https://app.codecov.io/gh/aio-libs/aiokafka/pull/1021/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | Coverage Δ | | |---|---|---| | [cext](https://app.codecov.io/gh/aio-libs/aiokafka/pull/1021/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `91.92% <96.57%> (-0.03%)` | :arrow_down: | | [integration](https://app.codecov.io/gh/aio-libs/aiokafka/pull/1021/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `94.64% <96.19%> (-0.03%)` | :arrow_down: | | [purepy](https://app.codecov.io/gh/aio-libs/aiokafka/pull/1021/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `94.48% <96.57%> (+0.02%)` | :arrow_up: | | [unit](https://app.codecov.io/gh/aio-libs/aiokafka/pull/1021/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `53.00% <64.25%> (+0.12%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.