search

aio-libs / aiokafka

asyncio client for kafka
http://aiokafka.readthedocs.io/
Apache License 2.0
1.13k stars 228 forks source link

Fix package publishing build #895

Closed selevit closed 1 year ago

selevit commented 1 year ago

For some reason there was the -e (editable) flag passed when doing pip install in github workflows.

It caused a build error like this: https://github.com/aio-libs/aiokafka/actions/runs/5129292520/jobs/9226766667.

Probably the base CI distro upgraded, or python is bumped to 3.8, that's why it eventually broke.

Removing the flag solved the issue. At least, I was able to reproduce the bug locally using act, and after removing the flag it worked.

codecov[bot] commented 1 year ago

Codecov Report

Merging #895 (6458305) into master (54b1cb9) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #895   +/-   ##
=======================================
  Coverage   97.56%   97.56%           
=======================================
  Files          30       30           
  Lines        5451     5451           
=======================================
  Hits         5318     5318           
  Misses        133      133
Flag Coverage Δ
cext 88.40% <ø> (ø)
integration 97.52% <ø> (ø)
purepy 97.02% <ø> (-0.08%) :arrow_down:
unit 38.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more