zschumacher
commented
1 year ago Add a new news fragment into the CHANGES folder
Not really sure what this means - do I need to create a CHANGES folder?
Closed zschumacher closed 1 year ago
zschumacher
commented
1 year ago Add a new news fragment into the CHANGES folder
Not really sure what this means - do I need to create a CHANGES folder?
codecov[bot]
commented
1 year ago Merging #912 (8a28c44) into master (772aa75) will not change coverage. Report is 1 commits behind head on master. The diff coverage is
100.00%.
@@ Coverage Diff @@
## master #912 +/- ##
=======================================
Coverage 97.56% 97.56%
=======================================
Files 30 30
Lines 5451 5451
=======================================
Hits 5318 5318
Misses 133 133 | Flag | Coverage Δ | |
|---|---|---|
| cext | 88.40% <100.00%> (ø) |
|
| integration | 97.52% <100.00%> (ø) |
|
| purepy | 97.10% <100.00%> (+0.03%) |
:arrow_up: |
| unit | 38.10% <100.00%> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Files Changed | Coverage Δ | |
|---|---|---|
| aiokafka/structs.py | 100.00% <100.00%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Changes
When using serialization frameworks like pydantic, I can not attach a consumer record because checksum can be None. Since it is marked as deprecated, it seems reasonable to mark it as optional here.
Checklist
CHANGESfolder<issue_id>.<type>(e.g.588.bugfix)issue_idchange it to the pr id after creating the PR.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.