Closed ods closed 7 months ago
Attention: 6 lines
in your changes are missing coverage. Please review.
Comparison is base (
88c6945
) 84.21% compared to head (b3d8a3c
) 84.25%.
Files | Patch % | Lines |
---|---|---|
aiokafka/codec.py | 85.00% | 3 Missing :warning: |
aiokafka/record/legacy_records.py | 0.00% | 2 Missing :warning: |
aiokafka/protocol/message.py | 50.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi,
I just noticed and wanted to let you know that the aiokafka.codec.ZSTD_MAX_OUTPUT_SIZE
constant seems to be an unused left-over from https://github.com/aio-libs/aiokafka/pull/940/files#diff-54e25ccbf1e01e453e8710de8482f86dc72917d1eec778100b73a4e5c52b5a3aR240
Best!
Thanks, @backbord! I'll remove it eventually
Changes
Fixes compatibility issue with Python 3.12 (see #931)
Checklist
CHANGES
folder<issue_id>.<type>
(e.g.588.bugfix
)issue_id
change it to the pr id after creating the PR.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.