aio-libs / aiokafka

asyncio client for kafka
http://aiokafka.readthedocs.io/
Apache License 2.0
1.09k stars 224 forks source link

Replace python-snappy and zstandard with cramjam #940

Closed ods closed 7 months ago

ods commented 7 months ago

Changes

Fixes compatibility issue with Python 3.12 (see #931)

Checklist

codecov[bot] commented 7 months ago

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (88c6945) 84.21% compared to head (b3d8a3c) 84.25%.

Files Patch % Lines
aiokafka/codec.py 85.00% 3 Missing :warning:
aiokafka/record/legacy_records.py 0.00% 2 Missing :warning:
aiokafka/protocol/message.py 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #940 +/- ## ========================================== + Coverage 84.21% 84.25% +0.03% ========================================== Files 87 87 Lines 10085 10039 -46 ========================================== - Hits 8493 8458 -35 + Misses 1592 1581 -11 ``` | [Flag](https://app.codecov.io/gh/aio-libs/aiokafka/pull/940/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | Coverage Δ | | |---|---|---| | [cext](https://app.codecov.io/gh/aio-libs/aiokafka/pull/940/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `79.29% <75.00%> (+0.04%)` | :arrow_up: | | [integration](https://app.codecov.io/gh/aio-libs/aiokafka/pull/940/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `84.23% <75.00%> (+0.03%)` | :arrow_up: | | [purepy](https://app.codecov.io/gh/aio-libs/aiokafka/pull/940/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `84.00% <75.00%> (+0.03%)` | :arrow_up: | | [unit](https://app.codecov.io/gh/aio-libs/aiokafka/pull/940/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `51.45% <75.00%> (-0.10%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

backbord commented 2 months ago

Hi,

I just noticed and wanted to let you know that the aiokafka.codec.ZSTD_MAX_OUTPUT_SIZE constant seems to be an unused left-over from https://github.com/aio-libs/aiokafka/pull/940/files#diff-54e25ccbf1e01e453e8710de8482f86dc72917d1eec778100b73a4e5c52b5a3aR240

Best!

ods commented 2 months ago

Thanks, @backbord! I'll remove it eventually