Implement KIP-345 in aiokafka (rebase of #827)

joshuaherrera commented 10 months ago

Changes

Fixes #680

This is a rebase of #827 that adds test for KIP-345 functionality - See #827 (comment)

Checklist

[ ] I think the code is well written
[ ] Unit tests for the changes exist
[ ] Documentation reflects the changes
[ ] Add a new news fragment into the CHANGES folder
- name it <issue_id>.<type> (e.g. 588.bugfix)
- if you don't have an issue_id change it to the pr id after creating the PR
- ensure type is one of the following:
- .feature: Signifying a new feature.
- .bugfix: Signifying a bug fix.
- .doc: Signifying a documentation improvement.
- .removal: Signifying a deprecation or removal of public API.
- .misc: A ticket has been closed, but it is not of interest to users.
- Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.

joshuaherrera commented 10 months ago

@ods Here's the PR for the tests, I'll work on getting merge conflicts fixed on my end since it's only two files, hopefully by EOD today.

Edit: Merge conflicts resolved.

codecov[bot] commented 10 months ago

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (d7201c1) 94.89% compared to head (5c60f63) 94.91%. Report is 1 commits behind head on master.

Files	Patch %	Lines
tests/test_consumer.py	97.58%	2 Missing and 1 partial :warning:
aiokafka/consumer/group_coordinator.py	95.23%	1 Missing and 1 partial :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #941 +/- ## ========================================== + Coverage 94.89% 94.91% +0.01% ========================================== Files 106 106 Lines 16136 16318 +182 Branches 2592 2615 +23 ========================================== + Hits 15313 15488 +175 - Misses 549 554 +5 - Partials 274 276 +2 ``` | [Flag](https://app.codecov.io/gh/aio-libs/aiokafka/pull/941/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | Coverage Δ | | |---|---|---| | [cext](https://app.codecov.io/gh/aio-libs/aiokafka/pull/941/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `91.59% <95.67%> (+0.01%)` | :arrow_up: | | [integration](https://app.codecov.io/gh/aio-libs/aiokafka/pull/941/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `94.56% <95.67%> (-0.01%)` | :arrow_down: | | [purepy](https://app.codecov.io/gh/aio-libs/aiokafka/pull/941/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `94.42% <95.67%> (+<0.01%)` | :arrow_up: | | [unit](https://app.codecov.io/gh/aio-libs/aiokafka/pull/941/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `44.90% <20.19%> (-0.30%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tvoinarovskyi commented 10 months ago

Hi joshuaherrera,

Thanks for the PR, will be joining the review. Really nice, clean PR, thanks for the contribution. Added a few small points to consider. Could you do a rebase to master, seems like we have a few broken CI runs due to upstream changes?