Closed uchiiii closed 7 months ago
This workflow requires approval from a maintainer.
@ods Sorry to bother you, but could you approve running workflow on this PR?
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
88c6945
) 84.21% compared to head (6178bcc
) 84.18%. Report is 12 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thank you for the approval for running workflows. I think the failed codecov is not an issue. Let me know if there is something to do.
@uchiiii, Thank you for your submission. The solution here just moves calculation from one place to another. This improves performance in one place and may (or may not) worsen it in others. Actually, this calculations are not needed in send at all, so I decided to proceed other way. Please review pr #946, does it solve your problem?
Changes
Fixes #943
Peformance
I reported #943 and re-measured the performance in the same environment after this improvement. Here is the summary of both before and after.
As for aiokafka producer, the performance is improved significantly. Messages / sec: 1842 -> 29929 MB / sec : 0.1757 -> 2.854
Checklist
CHANGES
folder<issue_id>.<type>
(e.g.588.bugfix
)issue_id
change it to the pr id after creating the PR.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.