aio-libs / aiokafka

asyncio client for kafka
http://aiokafka.readthedocs.io/
Apache License 2.0
1.09k stars 224 forks source link

Modify cluster metadata #942

Closed uchiiii closed 7 months ago

uchiiii commented 7 months ago

Changes

Fixes #943

Peformance

I reported #943 and re-measured the performance in the same environment after this improvement. Here is the summary of both before and after.

As for aiokafka producer, the performance is improved significantly. Messages / sec: 1842 -> 29929 MB / sec : 0.1757 -> 2.854

Checklist

uchiiii commented 7 months ago

This workflow requires approval from a maintainer.

@ods Sorry to bother you, but could you approve running workflow on this PR?

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (88c6945) 84.21% compared to head (6178bcc) 84.18%. Report is 12 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #942 +/- ## ========================================== - Coverage 84.21% 84.18% -0.03% ========================================== Files 87 87 Lines 10085 10088 +3 ========================================== Hits 8493 8493 - Misses 1592 1595 +3 ``` | [Flag](https://app.codecov.io/gh/aio-libs/aiokafka/pull/942/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | Coverage Δ | | |---|---|---| | [cext](https://app.codecov.io/gh/aio-libs/aiokafka/pull/942/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `79.24% <100.00%> (-0.01%)` | :arrow_down: | | [integration](https://app.codecov.io/gh/aio-libs/aiokafka/pull/942/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `84.16% <100.00%> (-0.03%)` | :arrow_down: | | [purepy](https://app.codecov.io/gh/aio-libs/aiokafka/pull/942/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `83.94% <100.00%> (-0.03%)` | :arrow_down: | | [unit](https://app.codecov.io/gh/aio-libs/aiokafka/pull/942/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `51.56% <66.66%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

uchiiii commented 7 months ago

Thank you for the approval for running workflows. I think the failed codecov is not an issue. Let me know if there is something to do.

ods commented 7 months ago

@uchiiii, Thank you for your submission. The solution here just moves calculation from one place to another. This improves performance in one place and may (or may not) worsen it in others. Actually, this calculations are not needed in send at all, so I decided to proceed other way. Please review pr #946, does it solve your problem?