search

aio-libs / aiokafka

asyncio client for kafka
http://aiokafka.readthedocs.io/
Apache License 2.0
1.09k stars 224 forks source link

Improve send performance (#943) #946

Closed ods closed 7 months ago

ods commented 7 months ago

Changes

Fixes #943

The results of benchmark/simple_produce_bench.py:

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b029fa2) 84.27% compared to head (3554731) 84.27%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #946 +/- ## ======================================= Coverage 84.27% 84.27% ======================================= Files 87 87 Lines 10039 10040 +1 ======================================= + Hits 8460 8461 +1 Misses 1579 1579 ``` | [Flag](https://app.codecov.io/gh/aio-libs/aiokafka/pull/946/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | Coverage Δ | | |---|---|---| | [cext](https://app.codecov.io/gh/aio-libs/aiokafka/pull/946/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `79.30% <100.00%> (+<0.01%)` | :arrow_up: | | [integration](https://app.codecov.io/gh/aio-libs/aiokafka/pull/946/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `84.25% <100.00%> (+<0.01%)` | :arrow_up: | | [purepy](https://app.codecov.io/gh/aio-libs/aiokafka/pull/946/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `84.02% <100.00%> (+0.01%)` | :arrow_up: | | [unit](https://app.codecov.io/gh/aio-libs/aiokafka/pull/946/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `51.45% <0.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ods commented 7 months ago

BTW, is it possible to make this fix available some way soon?

I'm going to include it into 0.9.0rc1, probably on Wednesday. Then we need some feedback before doing final release, especially from people using snappy and zsdt compression.

ods commented 7 months ago

Pre-release with fix is ready, please check

uchiiii commented 7 months ago

Thank you for your work. I confirmed everything worked well!