Closed ods closed 5 months ago
Attention: 4 lines
in your changes are missing coverage. Please review.
Comparison is base (
425ce26
) 94.92% compared to head (c4c5cd8
) 95.03%.
Files | Patch % | Lines |
---|---|---|
aiokafka/codec.py | 66.66% | 2 Missing and 2 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@ods Is there some resource about performance ? We are using lz4 in production on our end, mainly for performance reason and I wonder how cramjam will perform compared to the current lz4 lib
I think looking to cramjam benchmarks is not enough here, as I also switched from level=0 to level=9, because 9 is used by broker by default. Level is not configurable yet, so this may also affect you.
@ods Noted. We might get or lose few percents it seems, but it won't be probably a x factor increase, so I guess we can just wait to see how well it works for our cases. For us it is mostly read/uncompress, where we rebuilt an internal streaming state from a kafka changelog topic when our worker starts
Changes
Reduces number of dependencies
Checklist
CHANGES
folder<issue_id>.<type>
(e.g.588.bugfix
)issue_id
change it to the pr id after creating the PR.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.