aio-libs / aiokafka

asyncio client for kafka
http://aiokafka.readthedocs.io/
Apache License 2.0
1.08k stars 224 forks source link

Fix tagged fields handling #972

Closed ods closed 5 months ago

ods commented 5 months ago

Changes

Fix tagged fields handling

Checklist

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e8383ea) 95.04% compared to head (c54f257) 95.12%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #972 +/- ## ========================================== + Coverage 95.04% 95.12% +0.08% ========================================== Files 107 107 Lines 16408 16412 +4 Branches 2624 2625 +1 ========================================== + Hits 15595 15612 +17 + Misses 536 522 -14 - Partials 277 278 +1 ``` | [Flag](https://app.codecov.io/gh/aio-libs/aiokafka/pull/972/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | Coverage Δ | | |---|---|---| | [cext](https://app.codecov.io/gh/aio-libs/aiokafka/pull/972/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `91.82% <100.00%> (+0.06%)` | :arrow_up: | | [integration](https://app.codecov.io/gh/aio-libs/aiokafka/pull/972/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `94.75% <100.00%> (+0.06%)` | :arrow_up: | | [purepy](https://app.codecov.io/gh/aio-libs/aiokafka/pull/972/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `94.58% <100.00%> (+0.07%)` | :arrow_up: | | [unit](https://app.codecov.io/gh/aio-libs/aiokafka/pull/972/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `44.91% <37.50%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ods commented 5 months ago

@vmaurin Could you please review this one and check if it works for your DeleteRecords use cases?

vmaurin commented 5 months ago

@ods It looks it does still work. At the moment, it is still not used in production, just tested with a similar use case than the integration test