codecov[bot]
commented
5 months ago Codecov Report
Attention: 18 lines in your changes are missing coverage. Please review.
Comparison is base (
e8383ea) 95.04% compared to head (cc60fbe) 94.95%. Report is 3 commits behind head on master.
| Files | Patch % | Lines |
|---|---|---|
| tests/manual/topic_management.py | 0.00% | 18 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #973 +/- ## ========================================== - Coverage 95.04% 94.95% -0.09% ========================================== Files 107 108 +1 Lines 16408 16426 +18 Branches 2624 2626 +2 ========================================== + Hits 15595 15598 +3 - Misses 536 552 +16 + Partials 277 276 -1 ``` | [Flag](https://app.codecov.io/gh/aio-libs/aiokafka/pull/973/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | Coverage Δ | | |---|---|---| | [cext](https://app.codecov.io/gh/aio-libs/aiokafka/pull/973/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `91.67% <0.00%> (-0.09%)` | :arrow_down: | | [integration](https://app.codecov.io/gh/aio-libs/aiokafka/pull/973/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `94.60% <0.00%> (-0.09%)` | :arrow_down: | | [purepy](https://app.codecov.io/gh/aio-libs/aiokafka/pull/973/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `94.39% <0.00%> (-0.12%)` | :arrow_down: | | [unit](https://app.codecov.io/gh/aio-libs/aiokafka/pull/973/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `44.85% <0.00%> (-0.07%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Changes
The goal of this branch is to reproduce an error of not sending the create/delete topics command to the controller, and getting an error code 41, to then fix it in the admin client, as proposed in https://github.com/aio-libs/aiokafka/pull/865
Checklist
CHANGESfolder<issue_id>.<type>(e.g.588.bugfix)issue_idchange it to the pr id after creating the PR.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.