aio-libs / aiokafka

asyncio client for kafka
http://aiokafka.readthedocs.io/
Apache License 2.0
1.08k stars 224 forks source link

Fix type annotation for `AIOKafkaAdminClient.create_partitions` #978

Closed alm0ra closed 4 months ago

alm0ra commented 4 months ago

Fixes #977

Changes

Fixes wrong typo in create_partitions() for the admin client

Checklist

alm0ra commented 4 months ago

@tvoinarovskyi @ods

there is no documentation provided for AIOKafkaAdminClient so there is nothing to update and changes also for test, there is a test for this part test_admin that satisfy this change

alm0ra commented 4 months ago

@ods All resolved i think it's ready

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9166c96) 95.11% compared to head (6cb1375) 95.10%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #978 +/- ## ========================================== - Coverage 95.11% 95.10% -0.02% ========================================== Files 107 107 Lines 16412 16413 +1 Branches 2625 2625 ========================================== - Hits 15611 15610 -1 - Misses 522 523 +1 - Partials 279 280 +1 ``` | [Flag](https://app.codecov.io/gh/aio-libs/aiokafka/pull/978/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | Coverage Δ | | |---|---|---| | [cext](https://app.codecov.io/gh/aio-libs/aiokafka/pull/978/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `91.81% <100.00%> (-0.02%)` | :arrow_down: | | [integration](https://app.codecov.io/gh/aio-libs/aiokafka/pull/978/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `94.75% <100.00%> (+<0.01%)` | :arrow_up: | | [purepy](https://app.codecov.io/gh/aio-libs/aiokafka/pull/978/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `94.57% <100.00%> (-0.02%)` | :arrow_down: | | [unit](https://app.codecov.io/gh/aio-libs/aiokafka/pull/978/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `44.90% <100.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.