search

aio-libs / aiokafka

asyncio client for kafka
http://aiokafka.readthedocs.io/
Apache License 2.0
1.08k stars 224 forks source link

Drop unnecessary hack with WeakMethod #987

Closed ods closed 3 months ago

ods commented 3 months ago

Changes

Simplify code dropping unused feature (fixes security check complaints)

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 95.47%. Comparing base (331f6d5) to head (9bbd04a).

Files Patch % Lines
aiokafka/protocol/message.py 33.33% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #987 +/- ## ========================================== + Coverage 95.40% 95.47% +0.06% ========================================== Files 112 112 Lines 16730 16702 -28 Branches 2677 2674 -3 ========================================== - Hits 15962 15946 -16 + Misses 487 476 -11 + Partials 281 280 -1 ``` | [Flag](https://app.codecov.io/gh/aio-libs/aiokafka/pull/987/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | Coverage Δ | | |---|---|---| | [cext](https://app.codecov.io/gh/aio-libs/aiokafka/pull/987/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `92.17% <50.00%> (+0.04%)` | :arrow_up: | | [integration](https://app.codecov.io/gh/aio-libs/aiokafka/pull/987/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `95.12% <50.00%> (+0.06%)` | :arrow_up: | | [purepy](https://app.codecov.io/gh/aio-libs/aiokafka/pull/987/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `94.94% <50.00%> (+0.06%)` | :arrow_up: | | [unit](https://app.codecov.io/gh/aio-libs/aiokafka/pull/987/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `46.40% <50.00%> (-0.03%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.