refactor: add type hints to protocol - Githubissues

aio-libs / aiokafka

asyncio client for kafka

http://aiokafka.readthedocs.io/

Apache License 2.0

1.08k stars 224 forks source link

refactor: add type hints to protocol #997

Open odysa opened 2 months ago

odysa commented 2 months ago

Changes

Add type hints to the protocol module

Checklist

[x] I think the code is well written
[ ] Unit tests for the changes exist
[ ] Documentation reflects the changes
[ ] Add a new news fragment into the CHANGES folder
- name it <issue_id>.<type> (e.g. 588.bugfix)
- if you don't have an issue_id change it to the pr id after creating the PR
- ensure type is one of the following:
- .feature: Signifying a new feature.
- .bugfix: Signifying a bug fix.
- .doc: Signifying a documentation improvement.
- .removal: Signifying a deprecation or removal of public API.
- .misc: A ticket has been closed, but it is not of interest to users.
- Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.

antonagestam commented 17 hours ago

This PR seem to have been superseded, should it be closed?