search

aio-libs / aiomcache

Minimal asyncio memcached client
BSD 2-Clause "Simplified" License
141 stars 38 forks source link

set with_cas to false for single get #310

Closed jayzfbn closed 1 year ago

jayzfbn commented 1 year ago

One line quick fix for #111 Fixes #111

jayzfbn commented 1 year ago

@thehesiod fyi

Dreamsorcerer commented 1 year ago

I'm not familiar with what the CAS part is, so I'll defer to @thehesiod as to whether this is correct behaviour now.

jayzfbn commented 1 year ago

I think we're waiting for your approval @thehesiod

thehesiod commented 1 year ago

@Dreamsorcerer I actually proposed this change, so I approve of it =)

jayzfbn commented 1 year ago

@Dreamsorcerer I actually proposed this change, so I approve of it =)

Gotta get that green checkmark :-)

Dreamsorcerer commented 1 year ago

Yeah, sorry, more just me not getting back to it this week.

Dreamsorcerer commented 1 year ago

@jayzfbn @thehesiod If you're interested in doing a little more debugging, we seem to have some problems in aiocache when using aiomcache for the backend: https://github.com/aio-libs/aiocache/issues/585 https://github.com/aio-libs/aiocache/issues/587

jayzfbn commented 1 year ago

I'm currently dealing with a dying furnace at my house right now (fortunately I live in California so it's not that cold) but I could probably take a look at this in the coming weeks if you can wait that long.

Just to confirm we don't think this is directly related to the changes we were making just general debug/improvement, ya?

Dreamsorcerer commented 1 year ago

I'm currently dealing with a dying furnace at my house right now (fortunately I live in California so it's not that cold) but I could probably take a look at this in the coming weeks if you can wait that long.

Whenever you like, no rush.

Just to confirm we don't think this is directly related to the changes we were making just general debug/improvement, ya?

I don't believe so. Most of the tests have not been running on that repository for years, so I've just been getting everything up and running again, those are the still failing parts (though there are some warnings as well, which I'm trying to resolve now).