Closed achimnol closed 12 months ago
webknjaz
commented
12 months ago @achimnol I think it's the RTD requirement that is not yet compatible with merge queues: https://github.com/orgs/aio-libs/discussions/27#discussioncomment-7395467. We may have to drop it from the required checks.
Could you +1 this request? https://github.com/readthedocs/readthedocs.org/issues/10021
achimnol
commented
12 months ago @achimnol I think it's the RTD requirement that is not yet compatible with merge queues: github.com/orgs/aio-libs/discussions/27#discussioncomment-7395467. We may have to drop it from the required checks.
Could you +1 this request? readthedocs/readthedocs.org#10021
Just added a +1 there!
achimnol
commented
12 months ago After this, I'm going to update requirements-dev.txt to work with Python 3.12 as well via a separate PR.
achimnol
commented
12 months ago Ah... RTD is blocking the merge queue.... 😞 @webknjaz Until the RTD-side issue is resolved, could you temporarily remove RTD build from the required checks?
achimnol
commented
12 months ago Ummm... the test failure turned out to be a new regression introduced in Python 3.11.7 as GitHub Action began to use it. In my local setup, the test passes with Python 3.11.6 and breaks with Python 3.11.7...... T_T
achimnol
commented
12 months ago Currently blocked by vxgmichel/aioconsole#114
What do these changes do?
It improves Python 3.12 compatibility.
This PR relaxes our direct dependency to aiohttp to allow 3.9 and higher, by changing the requirement expression from
~=3.8.5to>=3.8.5, while pinning its version to 3.9.1 inrequirements-dev.txtused for local development and CI/CD tests. It also pins the uvloop version to 0.19.0 in the same way.aiohttp>=3.8.5aiohttp==3.9.1uvloop>=0.17.0uvloop==0.19.0aioconsole>=0.7.0aioconsole==0.7.0aiomonitor is a library that can be used various combinations of Python and aiohttp versions. The new aiohttp 3.9 release is required to run on Python 3.12, and there is no critical need to hold the aiohttp version back to the 3.8.x series to serve our webui.
In general, it is better to set the minimum compatible versions on our dependencies to maximize the dependency compatibility unless there are known critical regressions on specific versions.
This PR also sets the minimum required version of aioconsole to 0.7.0, to avoid the incompatibility issue with Python 3.11.7+ and 3.12.1+ (vxgmichel/aioconsole#114).
Are there changes in behavior for the user?
No.
Checklist
CHANGESfolder<issue_id>.<type>(e.g.588.bugfix)issue_idchange it to the pr id after creating the PR.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.