aio-libs / aiopg

aiopg is a library for accessing a PostgreSQL database from the asyncio

http://aiopg.readthedocs.io

BSD 2-Clause "Simplified" License

1.39k stars 159 forks source link

Multiple cursors support #801

Closed Pliner closed 3 years ago

Pliner commented 3 years ago

What do these changes do?

Support of multiple cursors which was initially proposed in #548 to resolve #535 and #364 by @vir-mir. I've slightly modified the implementation and rebased on top of master.

Are there changes in behavior for the user?

Related issue number

777, #535, #364, #548, #778

Checklist

[X] I think the code is well written
[X] Unit tests for the changes exist
[ ] Documentation reflects the changes

codecov[bot] commented 3 years ago

Codecov Report

Merging #801 (49824c3) into master (2e6e0f5) will increase coverage by 0.24%. The diff coverage is 94.85%.

@@            Coverage Diff             @@
##           master     #801      +/-   ##
==========================================
+ Coverage   93.20%   93.45%   +0.24%     
==========================================
  Files          13       13              
  Lines        1545     1542       -3     
  Branches      176      178       +2     
==========================================
+ Hits         1440     1441       +1     
+ Misses         76       72       -4     
  Partials       29       29

Impacted Files	Coverage Δ
aiopg/sa/result.py	`91.26% <62.50%> (-0.45%)`	:arrow_down:
aiopg/utils.py	`85.61% <84.61%> (+3.61%)`	:arrow_up:
aiopg/sa/connection.py	`87.30% <96.15%> (+0.97%)`	:arrow_up:
aiopg/connection.py	`91.36% <100.00%> (-0.47%)`	:arrow_down:
aiopg/pool.py	`100.00% <100.00%> (ø)`
aiopg/sa/engine.py	`100.00% <100.00%> (ø)`
aiopg/sa/transaction.py	`84.81% <100.00%> (+0.81%)`	:arrow_up:
aiopg/transaction.py	`100.00% <100.00%> (ø)`
aiopg/cursor.py	`99.40% <0.00%> (-0.60%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2e6e0f5...49824c3. Read the comment docs.

lgtm-com[bot] commented 3 years ago

This pull request fixes 1 alert when merging 48cde02b006672fd698f93028aacf6c3295dfced into 65ca604971a9d38db5ea53c9e24934f91c69b189 - view on LGTM.com

fixed alerts:

1 for Wrong number of arguments in a call

lgtm-com[bot] commented 3 years ago

This pull request fixes 4 alerts when merging e11c6fb1601422d9e77cf1e7af76bef35146d123 into 65ca604971a9d38db5ea53c9e24934f91c69b189 - view on LGTM.com

fixed alerts:

1 for Comparison using is when operands support `__eq__`
1 for Unnecessary 'else' clause in loop
1 for Module is imported with 'import' and 'import from'
1 for Wrong number of arguments in a call

lgtm-com[bot] commented 3 years ago

This pull request fixes 4 alerts when merging 5c4f92e92b839b24c697693531387ef37410a27d into 65ca604971a9d38db5ea53c9e24934f91c69b189 - view on LGTM.com

fixed alerts:

1 for Comparison using is when operands support `__eq__`
1 for Unnecessary 'else' clause in loop
1 for Module is imported with 'import' and 'import from'
1 for Wrong number of arguments in a call

lgtm-com[bot] commented 3 years ago

This pull request fixes 4 alerts when merging 6b2db0cd578001ae4b11b4dbb58dbce5b8a5aaf4 into 59671d3f4c4e6d8894a1b3d6762136371230f682 - view on LGTM.com

fixed alerts:

1 for Comparison using is when operands support `__eq__`
1 for Unnecessary 'else' clause in loop
1 for Module is imported with 'import' and 'import from'
1 for Wrong number of arguments in a call

lgtm-com[bot] commented 3 years ago

This pull request fixes 4 alerts when merging 164a47c3a70af32a27bfaf7cc819ec9a38763435 into 59671d3f4c4e6d8894a1b3d6762136371230f682 - view on LGTM.com

fixed alerts:

1 for Comparison using is when operands support `__eq__`
1 for Unnecessary 'else' clause in loop
1 for Module is imported with 'import' and 'import from'
1 for Wrong number of arguments in a call

lgtm-com[bot] commented 3 years ago

This pull request fixes 4 alerts when merging 774fd83b590a1ebc46b1b53215d5a6938ef5bedb into 2e6e0f5628b0010836437f649c811810b5cfde53 - view on LGTM.com

fixed alerts:

1 for Comparison using is when operands support `__eq__`
1 for Unnecessary 'else' clause in loop
1 for Module is imported with 'import' and 'import from'
1 for Wrong number of arguments in a call

lgtm-com[bot] commented 3 years ago

This pull request fixes 4 alerts when merging f44009bf1bf9555bc119ee091cc2f876a7fcf583 into 2e6e0f5628b0010836437f649c811810b5cfde53 - view on LGTM.com

fixed alerts:

1 for Comparison using is when operands support `__eq__`
1 for Unnecessary 'else' clause in loop
1 for Module is imported with 'import' and 'import from'
1 for Wrong number of arguments in a call

lgtm-com[bot] commented 3 years ago

This pull request fixes 4 alerts when merging 49824c3f457f6f578a5052b787048c0095ea5e9c into 2e6e0f5628b0010836437f649c811810b5cfde53 - view on LGTM.com

fixed alerts:

1 for Comparison using is when operands support `__eq__`
1 for Unnecessary 'else' clause in loop
1 for Module is imported with 'import' and 'import from'
1 for Wrong number of arguments in a call