aio-libs / aiopg

aiopg is a library for accessing a PostgreSQL database from the asyncio
http://aiopg.readthedocs.io
BSD 2-Clause "Simplified" License
1.4k stars 160 forks source link

aiopg1.2 incompatible with peewee-async #807

Closed inyutin closed 3 years ago

inyutin commented 3 years ago

Removing kwargs.pop('loop', None) in Multiple cursors support make peewee-async, library that used aiopg, incompatible. Probably, some other libraries affected too.

The thing is: before 1.2 you was allow to pass loop in kwargs. Before passing those kwargs to psycopg2, the loop parameter was popped. Now, it is not. Loop is passing to psycopg2 and we get error:

psycopg2.ProgrammingError: invalid dsn: invalid connection option "loop"
Pliner commented 3 years ago

https://pypi.org/project/aiopg/1.2.1/