search

aio-libs / aiopg

aiopg is a library for accessing a PostgreSQL database from the asyncio
http://aiopg.readthedocs.io
BSD 2-Clause "Simplified" License
1.4k stars 160 forks source link

pop loop in connection init due to backward compatibility #808

Closed inyutin closed 3 years ago

inyutin commented 3 years ago

What do these changes do?

This is fix to https://github.com/aio-libs/aiopg/issues/807

codecov[bot] commented 3 years ago

Codecov Report

Merging #808 (5086abe) into master (1545924) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #808   +/-   ##
=======================================
  Coverage   93.45%   93.45%           
=======================================
  Files          13       13           
  Lines        1542     1543    +1     
  Branches      178      178           
=======================================
+ Hits         1441     1442    +1     
  Misses         72       72           
  Partials       29       29
Impacted Files Coverage Δ
aiopg/connection.py 91.39% <100.00%> (+0.03%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1545924...5086abe. Read the comment docs.

Pliner commented 3 years ago

@inyutin Thanks for your contribution and sorry for this backward incompatible change