Closed Pliner closed 3 years ago
Merging #859 (261c4c7) into master (f68d9d5) will increase coverage by
0.05%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #859 +/- ##
==========================================
+ Coverage 93.36% 93.42% +0.05%
==========================================
Files 11 11
Lines 1553 1566 +13
Branches 182 184 +2
==========================================
+ Hits 1450 1463 +13
Misses 72 72
Partials 31 31
Impacted Files | Coverage Δ | |
---|---|---|
aiopg/connection.py | 95.83% <100.00%> (+<0.01%) |
:arrow_up: |
aiopg/utils.py | 91.34% <100.00%> (+1.12%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f68d9d5...261c4c7. Read the comment docs.
We had the following crutch to force reconnection, it was necessary before the fix #559.
It helped to find the issue in
ClosableQueue
implementation:ClosableQueue.get
doesn't handle cancellation well,get loop.create_task(self._queue.get())
is not cancelled if a cancellation happens inawait asyncio.wait([get, self._close_exception], return_when=asyncio.FIRST_COMPLETED)
.