Closed and-semakin closed 3 years ago
Merging #865 (1655124) into master (6df818c) will decrease coverage by
0.06%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #865 +/- ##
==========================================
- Coverage 93.43% 93.36% -0.07%
==========================================
Files 11 11
Lines 1568 1568
Branches 186 186
==========================================
- Hits 1465 1464 -1
- Misses 72 73 +1
Partials 31 31
Impacted Files | Coverage Δ | |
---|---|---|
aiopg/connection.py | 95.66% <0.00%> (-0.18%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 6df818c...1655124. Read the comment docs.
The PR template is a little bit outdated. It mentions some CHANGES
folder which I don't see anymore.
Thanks for the contribution.
What do these changes do?
Tests were using outdated/deprecated PostgreSQL versions. For better results tests should run over an actual PostgreSQL version.
I also had to remove some assertions in tests since they decided to phase out
oids
feature since PostgreSQL 12. See: https://stackoverflow.com/a/57022291/10650942Are there changes in behavior for the user?
No. Only in tests.
Checklist
CHANGES
folder<issue_id>.<type>
(e.g.588.bugfix
)issue_id
change it to the pr id after creating the PR.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.