aio-libs / aiopg

aiopg is a library for accessing a PostgreSQL database from the asyncio
http://aiopg.readthedocs.io
BSD 2-Clause "Simplified" License
1.39k stars 159 forks source link

Update PostgreSQL versions used in tests #865

Closed and-semakin closed 3 years ago

and-semakin commented 3 years ago

What do these changes do?

Tests were using outdated/deprecated PostgreSQL versions. For better results tests should run over an actual PostgreSQL version.

I also had to remove some assertions in tests since they decided to phase out oids feature since PostgreSQL 12. See: https://stackoverflow.com/a/57022291/10650942

Are there changes in behavior for the user?

No. Only in tests.

Checklist

codecov[bot] commented 3 years ago

Codecov Report

Merging #865 (1655124) into master (6df818c) will decrease coverage by 0.06%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #865      +/-   ##
==========================================
- Coverage   93.43%   93.36%   -0.07%     
==========================================
  Files          11       11              
  Lines        1568     1568              
  Branches      186      186              
==========================================
- Hits         1465     1464       -1     
- Misses         72       73       +1     
  Partials       31       31              
Impacted Files Coverage Δ
aiopg/connection.py 95.66% <0.00%> (-0.18%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6df818c...1655124. Read the comment docs.

and-semakin commented 3 years ago

The PR template is a little bit outdated. It mentions some CHANGES folder which I don't see anymore.

Pliner commented 3 years ago

Thanks for the contribution.