aio-libs / aiopg

aiopg is a library for accessing a PostgreSQL database from the asyncio
http://aiopg.readthedocs.io
BSD 2-Clause "Simplified" License
1.39k stars 159 forks source link

Run linters in CI #868

Closed and-semakin closed 3 years ago

and-semakin commented 3 years ago

What do these changes do?

The project seems to use flake8, mypy, black & isort but doesn't enforce it in the CI. This PR makes it necessary for these tools to pass successfully.

I had to # type: ignore one type errors. At the moment I don't have a clear understanding of how to fix this issue better. The PR still adds some value because all other parts of the project will be type-checked, and no new type violations will be allowed.

Are there changes in behavior for the user?

No. This PR affects only maintainers and future contributors.

Related issue number

Checklist

codecov[bot] commented 3 years ago

Codecov Report

Merging #868 (a446e02) into master (9048072) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #868   +/-   ##
=======================================
  Coverage   93.36%   93.36%           
=======================================
  Files          11       11           
  Lines        1568     1568           
  Branches      186      186           
=======================================
  Hits         1464     1464           
  Misses         73       73           
  Partials       31       31           
Impacted Files Coverage Δ
aiopg/utils.py 91.42% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9048072...a446e02. Read the comment docs.

Pliner commented 3 years ago

Thanks!