Closed gjcarneiro closed 2 years ago
Merging #878 (cb4dd54) into master (e131396) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #878 +/- ##
=======================================
Coverage 93.32% 93.32%
=======================================
Files 12 12
Lines 1574 1574
Branches 187 187
=======================================
Hits 1469 1469
Misses 73 73
Partials 32 32
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e131396...cb4dd54. Read the comment docs.
I'd love to have py.typed for aiopg in my projects; is there anything I can do to help get this PR merged?
I'd love to have py.typed for aiopg in my projects; is there anything I can do to help get this PR merged?
FYI, in my (docker based) code I just patched it like this:
# https://github.com/aio-libs/aiopg/pull/878
RUN touch /app/env/lib/python3.8/site-packages/aiopg/py.typed
You'll have to possibly adjust the path to the correct location for your case, but once the py.typed
file is created then mypy should start consulting aiopg for type annotations.
this library does not provide type hints completely. and now it broke Mypy
error: Call to untyped function "begin" in typed context [no-untyped-call]
error: Call to untyped function "execute" in typed context [no-untyped-call]
What do these changes do?
This package seems to to have type hints, but it is not signalling that it provides them. This adds the signal.
See PEP 561.
Are there changes in behavior for the user?
When doing type checking, aiopg is now consulted for typing information.
Related issue number
Checklist
CHANGES
folder<issue_id>.<type>
(e.g.588.bugfix
)issue_id
change it to the pr id after creating the PR.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.