aio-libs / aiopg

aiopg is a library for accessing a PostgreSQL database from the asyncio
http://aiopg.readthedocs.io
BSD 2-Clause "Simplified" License
1.4k stars 160 forks source link

fix Cursor.mogrify type hint: it returns bytes, not str #879

Closed gjcarneiro closed 3 years ago

gjcarneiro commented 3 years ago

What do these changes do?

the type hint for Cusor.mogrify is wrong. It returns bytes, not str (for proof, look for the unit test test_mogrify). This fixes the type hint, and inline doc.

Are there changes in behavior for the user?

Related issue number

Checklist

codecov[bot] commented 3 years ago

Codecov Report

Merging #879 (282b45c) into master (e131396) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #879   +/-   ##
=======================================
  Coverage   93.32%   93.32%           
=======================================
  Files          12       12           
  Lines        1574     1574           
  Branches      187      187           
=======================================
  Hits         1469     1469           
  Misses         73       73           
  Partials       32       32           
Impacted Files Coverage Δ
aiopg/connection.py 95.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e131396...282b45c. Read the comment docs.

Pliner commented 3 years ago

Thanks