aio-libs / aiopg

aiopg is a library for accessing a PostgreSQL database from the asyncio
http://aiopg.readthedocs.io
BSD 2-Clause "Simplified" License
1.39k stars 159 forks source link

Fix compatibility with SA 1.4.38. Pass escape_names. #891

Closed AVOstap closed 2 years ago

AVOstap commented 2 years ago

What do these changes do?

In version SA 1.4.38, a new argument was added to the signature of the construct_params method. To avoid such a problem in the future, parameters are passed through args, kwargs. This change is backward compatible

Are there changes in behavior for the user?

No

Related issue number

890 Incampatible with SQLAlchemy 1.4.38 and higher

Checklist

codecov[bot] commented 2 years ago

Codecov Report

Merging #891 (5e5cd9b) into master (7ac2d29) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #891   +/-   ##
=======================================
  Coverage   93.32%   93.32%           
=======================================
  Files          12       12           
  Lines        1574     1574           
  Branches      187      187           
=======================================
  Hits         1469     1469           
  Misses         73       73           
  Partials       32       32           
Impacted Files Coverage Δ
aiopg/sa/engine.py 99.13% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7ac2d29...5e5cd9b. Read the comment docs.

Pliner commented 2 years ago

Thanks @AVOstap. It looks good for me.