Closed AVOstap closed 2 years ago
Merging #891 (5e5cd9b) into master (7ac2d29) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #891 +/- ##
=======================================
Coverage 93.32% 93.32%
=======================================
Files 12 12
Lines 1574 1574
Branches 187 187
=======================================
Hits 1469 1469
Misses 73 73
Partials 32 32
Impacted Files | Coverage Δ | |
---|---|---|
aiopg/sa/engine.py | 99.13% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 7ac2d29...5e5cd9b. Read the comment docs.
Thanks @AVOstap. It looks good for me.
What do these changes do?
In version SA 1.4.38, a new argument was added to the signature of the
construct_params
method. To avoid such a problem in the future, parameters are passed through args, kwargs. This change is backward compatibleAre there changes in behavior for the user?
No
Related issue number
890 Incampatible with SQLAlchemy 1.4.38 and higher
Checklist
CHANGES
folder<issue_id>.<type>
(e.g.588.bugfix
)issue_id
change it to the pr id after creating the PR.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.