aio-libs / aiopg

aiopg is a library for accessing a PostgreSQL database from the asyncio
http://aiopg.readthedocs.io
BSD 2-Clause "Simplified" License
1.39k stars 159 forks source link

Add typing for aiopg.sa package #896

Closed hyzyla closed 1 year ago

hyzyla commented 1 year ago

What do these changes do?

Added a type hints for aiopg.sa package

Are there changes in behavior for the user?

-

Related issue number

-

Checklist

codecov[bot] commented 1 year ago

Codecov Report

Merging #896 (4b89334) into master (0b5e63c) will increase coverage by 0.72%. The diff coverage is 90.69%.

@@            Coverage Diff             @@
##           master     #896      +/-   ##
==========================================
+ Coverage   91.77%   92.50%   +0.72%     
==========================================
  Files           9       12       +3     
  Lines         863     1600     +737     
  Branches      118      191      +73     
==========================================
+ Hits          792     1480     +688     
- Misses         53       84      +31     
- Partials       18       36      +18     
Impacted Files Coverage Δ
aiopg/sa/transaction.py 83.13% <86.20%> (-1.68%) :arrow_down:
aiopg/sa/connection.py 86.51% <88.37%> (-1.53%) :arrow_down:
aiopg/sa/engine.py 97.52% <92.30%> (-1.62%) :arrow_down:
aiopg/sa/result.py 89.59% <93.44%> (-0.89%) :arrow_down:
aiopg/connection.py 95.66% <0.00%> (ø)
aiopg/utils.py 87.61% <0.00%> (ø)
aiopg/__init__.py 100.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Pliner commented 1 year ago

Hi @hyzyla,

Thanks for the contribution.

I am going to release this as beta and try on one of my work projects, where I had to suppress typing errors.