Closed mayty closed 1 year ago
Merging #901 (705faac) into master (0b5e63c) will increase coverage by
1.32%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #901 +/- ##
==========================================
+ Coverage 91.77% 93.09% +1.32%
==========================================
Files 9 12 +3
Lines 863 1579 +716
Branches 118 188 +70
==========================================
+ Hits 792 1470 +678
- Misses 53 77 +24
- Partials 18 32 +14
Files Changed | Coverage Δ | |
---|---|---|
aiopg/sa/engine.py | 99.17% <100.00%> (+0.03%) |
:arrow_up: |
aiopg/sa/result.py | 90.47% <100.00%> (ø) |
... and 3 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Hey @mayty,
Thank you for the contribution.
I have pushed CI changes (not ideal through) to run tests on both major versions of sqlalchemy.
The changes look reasonable for me, so I am happy to merge and release a new beta version.
@mayty Do you want to include any other additional changes into this PR?
Hi That's all the changes I want to include
But older version sqlalchemy test should probably be limited to >=1.4,<1.5
. They would fail on 1.3
due to new syntax
But older version sqlalchemy test should probably be limited to
>=1.4,<1.5
. They would fail on1.3
due to new syntax
Thanks for pointing this out. I have bumped a min supported sqlalchemy version to 1.4.
@mayty I was thinking to release it as 1.5 with a minor version bump. What do you think?
I agree
What do these changes do?
Fix SQLAlchemy 2.0 compatibility
Are there changes in behavior for the user?
No
Related issue number
897.bugfix
Checklist
CHANGES
folder<issue_id>.<type>
(e.g.588.bugfix
)issue_id
change it to the pr id after creating the PR.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.