Closed waynew closed 1 year ago
well, looks like that wouldn't actually help, doh! - though I'm wondering if I can ignore them in the sdist:
lists of files in version control and sdist do not match!
Looks like there's a bit more - I need to add the ignores to MANIFEST.in as well. I was also still seeing the QA fail - was failing on the news/version last check. I'll need to poke at that a bit more, too :thinking:
Okay, this works now.
Merging #312 (ad18704) into master (215b854) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #312 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 1686 1691 +5
Branches 307 314 +7
=========================================
+ Hits 1686 1691 +5
Impacted Files | Coverage Δ | |
---|---|---|
aiosmtpd/controller.py | 100.00% <100.00%> (ø) |
|
aiosmtpd/handlers.py | 100.00% <100.00%> (ø) |
|
aiosmtpd/proxy_protocol.py | 100.00% <100.00%> (ø) |
|
aiosmtpd/smtp.py | 100.00% <100.00%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Okay, assuming all the tests pass, this should be good to merge whenever. Will probably merge tomorrow afternoon if there are no objections.
No objections, so merging
What it says on the tin.
Was working on reviewing #311 and the qa tools complained, loudly, about my swap files :joy: