aio-libs / aiosmtpd

A reimplementation of the Python stdlib smtpd.py based on asyncio.
https://aiosmtpd.aio-libs.org
Apache License 2.0
319 stars 96 forks source link

Add vim swap files to gitignore #312

Closed waynew closed 1 year ago

waynew commented 1 year ago

What it says on the tin.

Was working on reviewing #311 and the qa tools complained, loudly, about my swap files :joy:

waynew commented 1 year ago

well, looks like that wouldn't actually help, doh! - though I'm wondering if I can ignore them in the sdist:

lists of files in version control and sdist do not match!

waynew commented 1 year ago

Looks like there's a bit more - I need to add the ignores to MANIFEST.in as well. I was also still seeing the QA fail - was failing on the news/version last check. I'll need to poke at that a bit more, too :thinking:

waynew commented 1 year ago

Okay, this works now.

codecov[bot] commented 1 year ago

Codecov Report

Merging #312 (ad18704) into master (215b854) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #312   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines         1686      1691    +5     
  Branches       307       314    +7     
=========================================
+ Hits          1686      1691    +5     
Impacted Files Coverage Δ
aiosmtpd/controller.py 100.00% <100.00%> (ø)
aiosmtpd/handlers.py 100.00% <100.00%> (ø)
aiosmtpd/proxy_protocol.py 100.00% <100.00%> (ø)
aiosmtpd/smtp.py 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

waynew commented 1 year ago

Okay, assuming all the tests pass, this should be good to merge whenever. Will probably merge tomorrow afternoon if there are no objections.

waynew commented 1 year ago

No objections, so merging