aio-libs / aiosmtpd

A reimplementation of the Python stdlib smtpd.py based on asyncio.
https://aiosmtpd.aio-libs.org
Apache License 2.0
313 stars 95 forks source link

Enhance GitHUB CI Workflow #324

Closed pepoluan closed 1 year ago

pepoluan commented 1 year ago

Speedup of #323 + many modernizations, such as:

And a workaround:

Now all steps are green and runs in acceptable time, as can be seen in CI #451

If merged this closes #316

pepoluan commented 1 year ago

When this is merged, we can again be sure that our CI no longer raises false alarm, and I can package & tag 1.4.3.

codecov[bot] commented 1 year ago

Codecov Report

Merging #324 (752fae9) into master (c78fc95) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #324   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines         1691      1696    +5     
  Branches       314       310    -4     
=========================================
+ Hits          1691      1696    +5     
Impacted Files Coverage Δ
aiosmtpd/smtp.py 100.00% <100.00%> (ø)
aiosmtpd/handlers.py 100.00% <0.00%> (ø)
aiosmtpd/controller.py 100.00% <0.00%> (ø)
aiosmtpd/proxy_protocol.py 100.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

pepoluan commented 1 year ago

If no objections within say 2x24 hours I will squamerge, then package the code so far into 1.4.3.

Hopefully can answer the "severe/critical" blocker Debian maintainer are facing right now (as mentioned in #322 )

pepoluan commented 1 year ago

Testing with the latest commit 752fae9 : All is green

Can squamerge this.

After this is merged: Bump the version, update NEWS.rst, release new version here and in PyPI.