Open alexmv opened 1 year ago
Merging #370 (bedda90) into master (83168cd) will not change coverage. The diff coverage is
100.00%
.:exclamation: Current head bedda90 differs from pull request most recent head 9182c42. Consider uploading reports for the commit 9182c42 to get more accurate results
@@ Coverage Diff @@
## master #370 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 1706 1707 +1
Branches 310 310
=========================================
+ Hits 1706 1707 +1
Impacted Files | Coverage Δ | |
---|---|---|
aiosmtpd/main.py | 100.00% <100.00%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Thanks for the review! I've repushed with your documentation change.
I do have a slight concern that there might be a better way to have the other connections made and then drop privileges to nobody... but I don't think that's necessarily a blocker here.
I don't think there is -- neither root
nor nobody
can auth, so both making the connections before or after calling suid(nobody)
isn't feasible.
Gentle nudge on this -- anything I can do to help move this forward?
What do these changes do?
We may want a different user than
nobody
when dropping permissions -- for example, if we intend to connect to a PostgreSQL database which doesident
authentication.Are there changes in behavior for the user?
No behaviour change.
Checklist
{py36,py37,py38,py39}-{nocov,cov,diffcov}, qa, docs
{py36,py37,py38,py39}-{nocov,cov,diffcov}
{py36,py37,py38,py39}-{nocov,cov,diffcov}, pypy3-{nocov,cov}, qa, docs
{py36,pypy3}-{nocov,cov,diffcov}, qa
py36-{nocov,cov,diffcov}, qa, docs
NEWS.rst
file