search

aio-libs / aiosmtpd

A reimplementation of the Python stdlib smtpd.py based on asyncio.
https://aiosmtpd.aio-libs.org
Apache License 2.0
312 stars 95 forks source link

Controller.start() is missing type annotation #386

Closed cuu508 closed 1 month ago

cuu508 commented 8 months ago

The aiosmtpd library has the py.typed marker (awesome!), but the aiosmtpd.controller.Controller.start() method has no type annotation for the return type. This leads to a mypy warning in calling code (when run with --strict):

path/to/file.py:141: error: Call to untyped function "start" in typed context  [no-untyped-call]

Looking at the source, seems it could be annotated to return None.