search

aio-libs / aiozmq

Asyncio (pep 3156) integration with ZeroMQ
aiozmq.readthedocs.org
BSD 2-Clause "Simplified" License
422 stars 56 forks source link

Remove usage of asyncio.test_utils #146

Closed JelleZijlstra closed 5 years ago

JelleZijlstra commented 6 years ago

In Python 3.7, asyncio.test_utils was renamed to make it clear that it is private (python/cpython#4785). Unfortunately, aiozmq relies on it fairly extensively. In this PR, I copy over the implementation of TestLoop from current CPython master in the absence of a better option.

codecov[bot] commented 5 years ago

Codecov Report

Merging #146 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #146      +/-   ##
==========================================
+ Coverage    92.4%   92.41%   +<.01%     
==========================================
  Files          14       14              
  Lines        1633     1634       +1     
  Branches      271      271              
==========================================
+ Hits         1509     1510       +1     
  Misses        101      101              
  Partials       23       23
Impacted Files Coverage Δ
aiozmq/rpc/__init__.py 100% <ø> (ø) :arrow_up:
aiozmq/rpc/pubsub.py 100% <100%> (ø) :arrow_up:
aiozmq/core.py 97.93% <100%> (ø) :arrow_up:
aiozmq/selector.py 96.89% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9ff53bf...7570773. Read the comment docs.