search

aio-libs / aiozmq

Asyncio (pep 3156) integration with ZeroMQ
aiozmq.readthedocs.org
BSD 2-Clause "Simplified" License
422 stars 56 forks source link

Use msgpack instead of msgpack-python #154

Closed blueyed closed 5 years ago

blueyed commented 5 years ago

Follow-up to https://github.com/aio-libs/aiozmq/pull/148 - mainly to see if builds get stuck here, too.

But it should also be replaced throughout the codebase anyway.

codecov[bot] commented 5 years ago

Codecov Report

Merging #154 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #154   +/-   ##
=======================================
  Coverage   92.41%   92.41%           
=======================================
  Files          14       14           
  Lines        1634     1634           
  Branches      271      271           
=======================================
  Hits         1510     1510           
  Misses        101      101           
  Partials       23       23
Impacted Files Coverage Δ
aiozmq/rpc/__init__.py 100% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1765fbd...f96ecbb. Read the comment docs.

JelleZijlstra commented 5 years ago

Thank you!

blueyed commented 5 years ago

You're welcome! Came here again because of py37 not working with the latest release still, and hopefully this helps to get it on track a bit more.

JelleZijlstra commented 5 years ago

Yes, I need to get back to that... the last time I tried I ran into some mysterious failures and didn't manage to get it working under 3.7. If you're interested, I'm happy to review pull requests adding 3.7 support.

blueyed commented 5 years ago

I assume https://github.com/aio-libs/aiozmq/pull/146 is very relevant here. Maybe rebase this and try again from there?